From owner-freebsd-hackers@FreeBSD.ORG  Fri Mar  2 20:49:08 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F33821065670
	for <hackers@freebsd.org>; Fri,  2 Mar 2012 20:49:08 +0000 (UTC)
	(envelope-from seanbru@yahoo-inc.com)
Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com
	[98.139.253.104])
	by mx1.freebsd.org (Postfix) with ESMTP id A93EC8FC18
	for <hackers@freebsd.org>; Fri,  2 Mar 2012 20:49:08 +0000 (UTC)
Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231])
	by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id
	q22KcjZa035380; Fri, 2 Mar 2012 12:38:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com;
	s=cobra; t=1330720725;
	bh=2isr3s+fR949bOka5k1HPg6yEYzMbJVQpmC6P+yxW1Q=;
	h=Subject:From:Reply-To:To:Content-Type:Date:Message-ID:
	Mime-Version;
	b=r/gr74pcTJYXGk0PIfdo7Kcmpz+cKn4msPdbakw4MUgKmc3x1R24uCUsCr+KqXU71
	/PliEg9iMi0rb1fki9/RxrgPA0cwQFj7KVgIvoO42pCYGgH0jXHRS0pCu1J27nBcXA
	pWDxu0zXpXdnWC3Tk2GQFU5YJfjfTjsFYhm2zEsw=
From: Sean Bruno <seanbru@yahoo-inc.com>
To: hackers@freebsd.org
Content-Type: multipart/signed; micalg="pgp-sha1";
	protocol="application/pgp-signature";
	boundary="=-fBr89LSh/s3j85QKJKm1"
Date: Fri, 02 Mar 2012 12:38:44 -0800
Message-ID: <1330720724.5391.2.camel@powernoodle-l7.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Cc: 
Subject: [patch] Disable bios probe if acpi is enabled
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: sbruno@freebsd.org
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2012 20:49:09 -0000


--=-fBr89LSh/s3j85QKJKm1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I'm noting that newer machines are completely hosed if we attempt to
probe for bios values.  I'm proposing this change.

-bash-4.2$ p4 diff -du //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c
--- //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c       2011-09-16
22:47:30.000000000 0000
+++ /home/seanbru/ybsd_7/src/sys/i386/i386/bios.c       2011-09-16
22:47:30.000000000 0000
@@ -84,6 +84,12 @@
     char                       *p;
    =20
     /*
+     * Don't do bios probing if acpi is enabled, its
+     * pointless and breaks on newer systems
+     */
+    if (!resource_disabled("acpi", 0))
+       return;
+    /*
      * BIOS32 Service Directory, PCI BIOS
      */


--=-fBr89LSh/s3j85QKJKm1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAABAgAGBQJPUS/UAAoJEL2UHwafTLtO5iYH/1C0Rpfo1UHFHnhn0G7qHscl
WJGeScyGo3UaMuqUIHYJV/HEYirzUxCfzG6xYC6ple1OMAb6zfGqCapB2NnIQSgn
JcnQKImsfdyrw6y/iyO+0vPm3GghI4qC5zokT1khvdGjf1hK1TOIEshJ5+jg08bn
wxQEvM9js6aunEq1POpYd0fgpa+H3UTv2/uYTi/5lk4pCth8c22ZGb1I644RkOj+
/7wP2LPLCpWOw6g7jqQ50o3CyQgaeo3cMh8LUVFvkd0L4txjyeuOd/ErRZf12u9x
DMVErsYcGGAhhEPdS2MQCMZXjxgnpdCIiz24tqsqHMjXTeviD6YkZM7aMEeVTkc=
=N1u9
-----END PGP SIGNATURE-----

--=-fBr89LSh/s3j85QKJKm1--