Date: Fri, 5 May 2017 11:40:14 +0100 From: Steven Hartland <killing@multiplay.co.uk> To: freebsd-ports@freebsd.org Subject: Re: diff and submissions Message-ID: <aa4bed05-c5dc-9453-eb74-5d7eeeb74a83@multiplay.co.uk> In-Reply-To: <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org> References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> <20170505102006.5lzf6kt7rotzvzeg@ivaldir.net> <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/05/2017 11:27, Mathieu Arnold wrote: > Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit : >> On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote: >>> Le 05/05/2017 à 08:16, Franco Fichtner a écrit : >>>>> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: >>>>> >>>>> If you went as far as being able to create a pull request, you can do a >>>>> git show HEAD or git diff origin/trunk...HEAD and submit that in the >>>>> FreeBSD PR as well. >>>> It's pretty easy to extract the diff from a PR on GitHub, just append >>>> ".diff", and ".patch" works too, but gives the full git commit history: >>>> >>>> https://github.com/freebsd/freebsd-ports/pull/62.diff >>> Yes, I am aware of that, the problem with github pull requests is that >>> they are outside of the FreeBSD bug report process, they do not get >>> assigned to maintainers, nobody notices them, they just stay there, and >>> get obsolete. >>> There have been 61 before, yes, I closed a lot because they were >>> obsolete because it is outside of our process and nobody noticed them, >>> and for the rest either asked the submitter to open a PR on our >>> bugzilla, or opened one myself. >>> >> I made a script which is a few lines of shell that converts pull requests to >> phabricator reviews automatically. >> >> I have handed it to some of the phabricator admins, I hope it will be progress >> soon. > > Please, do not do that. > > Phabricator is for code review, not bug reports. It all ends up in our > repository, but Phabricator does not have any maintainer notification > like Bugzilla has. > robak@ has a script that does pull-request -> bugzilla, and it has been > waiting for months for someone with access to do something about it. Pull requests are not bug reports, that would issues. IMO PR -> phabricator would be best match. Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aa4bed05-c5dc-9453-eb74-5d7eeeb74a83>