From owner-freebsd-bugs  Mon Jul  2 16: 0:26 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 30B2037B403
	for <freebsd-bugs@hub.freebsd.org>; Mon,  2 Jul 2001 16:00:19 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f62N0Jh64672;
	Mon, 2 Jul 2001 16:00:19 -0700 (PDT)
	(envelope-from gnats)
Date: Mon, 2 Jul 2001 16:00:19 -0700 (PDT)
Message-Id: <200107022300.f62N0Jh64672@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Dima Dorfman <dima@unixfreak.org>
Subject: Re: kern/28628: small indentation change to /sys/kern/kern_sysctl.c 
Reply-To: Dima Dorfman <dima@unixfreak.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR kern/28628; it has been noted by GNATS.

From: Dima Dorfman <dima@unixfreak.org>
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/28628: small indentation change to /sys/kern/kern_sysctl.c 
Date: Mon, 02 Jul 2001 15:55:52 -0700

 Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
 > Index: kern_sysctl.c
 > ===================================================================
 > RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v
 > retrieving revision 1.110
 > diff -c -t -r1.110 kern_sysctl.c
 > *** kern_sysctl.c	2001/06/22 19:54:38	1.110
 > --- kern_sysctl.c	2001/07/02 09:11:51
 > ***************
 > *** 1027,1033 ****
 >           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
 >               req->newptr && req->p &&
 >               (error = suser_xxx(0, req->p, 
 > !             (oid->oid_kind & CTLFLAG_PRISON) ? PRISON_ROOT : 0)))
 >                   return (error);
 >   
 >           if (!oid->oid_handler)
 > --- 1027,1034 ----
 >           if (!(oid->oid_kind & CTLFLAG_ANYBODY) &&
 >               req->newptr && req->p &&
 >               (error = suser_xxx(0, req->p, 
 > !                          (oid->oid_kind & CTLFLAG_PRISON) ?  PRISON_ROOT : 0)))
 > ! 
 >                   return (error);
 
 This change introduces two style bugs: (1) secondary indents are four,
 not eight spaces, and (2) lines should be <= 80 characters.
 Obviously, fixing (1) will fix (2) as well.  That said, I don't think
 it makes sense to file PRs for minor style fixes.  There are a lot
 more places in the tree where more serious violations are made, and
 not only would it take you a long time to find and fix all of them,
 I'm not sure anybody would want to commit them for you; it's just too
 much trouble for too little gain.
 
 					Dima Dorfman
 					dima@unixfreak.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message