From owner-freebsd-current@FreeBSD.ORG Sat Oct 2 08:39:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E426316A4CE for ; Sat, 2 Oct 2004 08:39:32 +0000 (GMT) Received: from node15.coopprint.com (node15.cooperativeprinting.com [208.4.77.15]) by mx1.FreeBSD.org (Postfix) with SMTP id 2CB6843D45 for ; Sat, 2 Oct 2004 08:39:32 +0000 (GMT) (envelope-from ryans@gamersimpact.com) Received: (qmail 47365 invoked by uid 0); 2 Oct 2004 08:38:58 -0000 Received: from unknown (HELO ?192.168.0.5?) (63.231.165.205) by node15.coopprint.com with SMTP; 2 Oct 2004 08:38:58 -0000 Message-ID: <415E6944.10105@gamersimpact.com> Date: Sat, 02 Oct 2004 03:39:32 -0500 From: Ryan Sommers User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David G. Lawrence" References: <200410020349.i923nG8v021675@northstar.hetzel.org> <20041002052856.GE17792@nexus.dglawrence.com> In-Reply-To: <20041002052856.GE17792@nexus.dglawrence.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: "Scot W. Hetzel" cc: freebsd-current@freebsd.org Subject: Re: Bug in #! processing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Oct 2004 08:39:33 -0000 David G. Lawrence wrote: >>The following patch changes the check for end of line, so that a comment >>on the first line must be preceded by white space (' ' or '\t'). >> >> > > Personally, I'm thinking that all of the support for a "comment" on >the interpreter line is bogus and it would be better to back out rev >1.21 rather than add even more complicated code to work around all of >the problems that it causes. > >-DG > > I tend to agree. I don't really see adding comments on the first line as being all that necessary or useful of a feature personally. However, as someone mentioned this has been in for almost 5 years and it's equally bad to break a feature some might have come to rely on. I'm not sure I like adding a sysctl for something as trivial as this either, something along the lines of kernel bloat. But if that's the best solution to incrementally back this out then I guess it has to be. Perhaps this is something that should be taken to arch@ for further discussion. -- Ryan Sommers ryans@gamersimpact.com