From owner-svn-ports-head@freebsd.org Fri Oct 12 21:45:15 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5B4910CBD59; Fri, 12 Oct 2018 21:45:15 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 326E277548; Fri, 12 Oct 2018 21:45:14 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.6] (unknown [75.161.243.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 90CEB1AFBDA; Fri, 12 Oct 2018 13:49:03 +0000 (UTC) Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files To: Mathieu Arnold Cc: Tobias Kortkamp , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> From: Sean Bruno Openpgp: preference=signencrypt Autocrypt: addr=sbruno@freebsd.org; prefer-encrypt=mutual; keydata= xsBNBFk+0UEBCADaf4bgxxKvMOhRV5NPoGWRCCGm49d6+1VFNlQ77WsY/+Zvf95TPULdRlnG w648KfxWt7+O3kdKhdRwnqlXWC7zA2Qt0dRE1yIqOGJ4jp4INvp/bcxWzgr0aoKOjrlnfxRV bh+s0rzdZt6TsNL3cVYxkC8oezjaUkHdW4mFJU249U1QJogkF8g0FeKNfEcjEkwJNX6lQJH+ EzCWT0NCk6J+Xyo+zOOljxPp1OUfdvZi3ulkU/qTZstGVWxFVsP8xQklV/y3AFcbIYx6iGJ4 5L7WuB0IWhO7Z4yHENr8wFaNYwpod9i4egX2BugbrM8pOfhN2/qqdeG1L5LMtXw3yyAhABEB AAHNN1NlYW4gQnJ1bm8gKEZyZWVCU0QgRGV2ZWxvcGVyIEtleSkgPHNicnVub0BmcmVlYnNk Lm9yZz7CwJQEEwEKAD4WIQToxOn4gDUE4eP0ujS95PX+ibX8tgUCWT7RQQIbAwUJBaOagAUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRC95PX+ibX8ttKTCACFKzRc56EBAlVotq02EjZP SfX+unlk6AuPBzShxqRxeK+bGYVCigrYd1M8nnskv0dEiZ5iYeND9HIxbpEyopqgpVTibA7w gBXaZ7SOEhNX1wXwg14JrralfSmPFMYni+sWegPMX/zwfAsn1z4mG1Nn44Xqo3o7CfpkMPy6 M5Bow2IDzIhEYISLR+urxs74/aHU35PLtBSDtu18914SEMDdva27MARN8mbeCDbuJVfGCPWy YHuy2t+9u2Zn5Dd+t3sBXLM9gpeaMm+4x6TNPpESygbVdh4tDdjVZ9DK/bWFg0kMgfZoaq6J l0jNsQXrZV3bzYNFbVw04pFcvA2GIJ7xzsBNBFk+0UEBCADIXBmQOaKMHGbc9vwjhV4Oj5aZ DdhNedn12FVeTdOXJvuTOusgxS29lla0RenHGDsgD08UiFpasBXWq/E+BhQ19d+iRbLLR17O KKc1ZGefoVbLARLXD68J5j4XAyK+6k2KqBLlqzAEpHTzsksM9naARkVXiEVcrt6ciw0FSm8n kuK3gDKKe93XfzfP+TQdbvvzJc7Fa+appLbXz61TM1aikaQlda8bWubDegwXbuoJdB34xU1m yjr/N4o+raL0x7QrzdH+wwgrTTo+H4S2c1972Skt5K5tbxLowfHicRl23V8itVQr3sBtlX4+ 66q+Apm7+R36bUS/k+G45Sp6iPpxABEBAAHCwHwEGAEKACYWIQToxOn4gDUE4eP0ujS95PX+ ibX8tgUCWT7RQQIbDAUJBaOagAAKCRC95PX+ibX8trrIB/9Pljqt/JGamD9tx4dOVmxSyFg9 z2xzgklTLuDgS73MM120mM7ao9AQUeWiSle/H0UCK7xPOzC/aeUC4oygDQKAfkkNbCNTo3+A qDjBRA8qx0e9a/QjDL+RFgD4L5kLT4tToY8T8HaBp8h03LBfk510IaI8oL/Jg7vpM3PDtJMW tUi2H+yNFmL3NfM2oBToWKLFsoP54f/eeeImrNnrlLjLHPzqS+/9apgYqX2Jwiv3tHBc4FTO GuY8VvF7BpixJs8Pc2RUuCfSyodrp1YG1kRGlXAH0cqwwr0Zmk4+7dZvtVQMCl6kS6q1+84q JwtItxS2eXSEA4NO0sQ3BXUywANh Message-ID: Date: Fri, 12 Oct 2018 15:45:10 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 21:45:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj Content-Type: multipart/mixed; boundary="ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU"; protected-headers="v1" From: Sean Bruno To: Mathieu Arnold Cc: Tobias Kortkamp , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> <7010c7ad-24a6-fadd-ae7e-8623d827e066@freebsd.org> <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> In-Reply-To: <20181012213623.54l4p6e5debtflru@atuin.in.mat.cc> --ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/12/18 3:36 PM, Mathieu Arnold wrote: > On Fri, Oct 12, 2018 at 02:55:38PM -0600, Sean Bruno wrote: >> >> >> On 10/12/18 2:10 PM, Mathieu Arnold wrote: >>> So, you want us to add something like "if the variable EXTRA_PATCHES = is >>> already set before, instead of using =3D, use +=3D"? >>> >>> I don't really see it happening, we are not going to state all the >>> possible cases, the porter's handbook would end up being ISO9001 and = 50k >>> pages long, we assume that you know make(1), so that when you add a >>> variable, you actually look for it in the Makefile to see if it is no= t >>> already set. >> >> I don't think I'm asking for that. >> >> I think I'm asking for "we should have the example be a +=3D instead o= f a >> =3D" because of the DOCS variable and how it behaves. EXTRA_PATCHES >> wasn't in use in this example before I added the openssl1.1.1 patch >> abomination, but I guess, DOCS implicitly means its always in use. >=20 > The example is GENERIC. THIS port has a DOCS option that sets > EXTRA_PATCHES. >=20 Ah, gotcha. I looked around in the handbook to see if I overlooked this behavior. I didn't see it in there, but I may have missed it. sean --ySa79FfN602GWGEoa0hgx4NbVH9wGYHQU-- --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlvBFelfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LZXOQf7BeAgqu2C2jtcMs00VsV2evxWRyIoxEsDD53g1O1Lh/Om/8ls5HQ0MuJr mDmFKmqcj/9z3NWeh6UBg1rLrCifZ0619NAeCbIFfau4b4wYBf5AP/ABp8XL5X1G BfKDt4EOHq93MRSMbIojWTk14b3jQ4Lk0JZaGABCKO3jPbKBCVgtKuFJ3zJFNIRE NktvViT//fK/rw11jcdwfdEFQ/NeiztNxvCDiyDHGkv8aGT4YCpZsbFmeGkGku/D nCu078N7KGoWCYLp4a5tKyu0HbFX/CCAgw1h2ZIGsCyzhYmlb2mHr/Sb56QXwaWp efx4FwglmZKVozQNkPKEND2UFYE7yw== =XXJW -----END PGP SIGNATURE----- --QRvfoeSpYmzE23wcR2xdkhj8ct7fs3cuj--