From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 19 07:50:13 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 16A4A106564A for ; Mon, 19 Mar 2012 07:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DF7968FC26 for ; Mon, 19 Mar 2012 07:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2J7oC3A042945 for ; Mon, 19 Mar 2012 07:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2J7oC71042944; Mon, 19 Mar 2012 07:50:12 GMT (envelope-from gnats) Resent-Date: Mon, 19 Mar 2012 07:50:12 GMT Resent-Message-Id: <201203190750.q2J7oC71042944@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pavel Timofeev Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B3F6106566B for ; Mon, 19 Mar 2012 07:49:50 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0D75B8FC0C for ; Mon, 19 Mar 2012 07:49:50 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2J7nnGs051694 for ; Mon, 19 Mar 2012 07:49:49 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q2J7nnkt051693; Mon, 19 Mar 2012 07:49:49 GMT (envelope-from nobody) Message-Id: <201203190749.q2J7nnkt051693@red.freebsd.org> Date: Mon, 19 Mar 2012 07:49:49 GMT From: Pavel Timofeev To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/166239: missing module dependencies X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 07:50:13 -0000 >Number: 166239 >Category: kern >Synopsis: missing module dependencies >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 19 07:50:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Pavel Timofeev >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: >Description: hptiop(4), hptmv(4) and isp(4) don't have necessary dependencies for loading themselves as modules. Obtained from (see all thread) http://lists.freebsd.org/pipermail/freebsd-stable/2012-March/066607.html http://lists.freebsd.org/pipermail/freebsd-scsi/2012-March/005333.html >How-To-Repeat: remove such devices from kernconf. then recompile kernel and try to load hptiop(4), hptmv(4) and isp(4) as modules. >Fix: see attached patch Patch attached with submission follows: --- /sys/dev/hptiop/hptiop.c 2012-03-12 12:03:51.000000000 +0400 +++ ./hptiop/hptiop.c 2012-03-11 13:14:49.000000000 +0400 @@ -1268,6 +1268,7 @@ }; DRIVER_MODULE(hptiop, pci, hptiop_pci_driver, hptiop_devclass, 0, 0); +MODULE_DEPEND(hptiop, cam, 1, 1, 1); static int hptiop_probe(device_t dev) { --- /sys/dev/hptmv/entry.c 2012-03-12 12:03:51.000000000 +0400 +++ ./hptmv/entry.c 2012-03-11 13:15:14.000000000 +0400 @@ -108,6 +108,7 @@ #define __DRIVER_MODULE(p1, p2, p3, p4, p5, p6) DRIVER_MODULE(p1, p2, p3, p4, p5, p6) __DRIVER_MODULE(PROC_DIR_NAME, pci, hpt_pci_driver, hpt_devclass, 0, 0); +MODULE_DEPEND(PROC_DIR_NAME, cam, 1, 1, 1); #define ccb_ccb_ptr spriv_ptr0 #define ccb_adapter ccb_h.spriv_ptr1 --- /sys/dev/isp/isp_pci.c 2011-11-16 06:52:24.000000000 +0400 +++ ./isp/isp_pci.c 2012-03-13 11:28:28.000000000 +0400 @@ -372,6 +372,8 @@ }; static devclass_t isp_devclass; DRIVER_MODULE(isp, pci, isp_pci_driver, isp_devclass, 0, 0); +MODULE_DEPEND(isp, cam, 1, 1, 1); +MODULE_DEPEND(isp, firmware, 1, 1, 1); static int isp_pci_probe(device_t dev) --- /sys/dev/isp/isp_sbus.c 2011-02-15 00:50:51.000000000 +0300 +++ ./isp/isp_sbus.c 2012-03-13 11:28:43.000000000 +0400 @@ -106,6 +106,8 @@ }; static devclass_t isp_devclass; DRIVER_MODULE(isp, sbus, isp_sbus_driver, isp_devclass, 0, 0); +MODULE_DEPEND(isp, cam, 1, 1, 1); +MODULE_DEPEND(isp, firmware, 1, 1, 1); static int isp_sbus_probe(device_t dev) >Release-Note: >Audit-Trail: >Unformatted: