From owner-freebsd-gnome@FreeBSD.ORG Wed Apr 20 20:34:13 2005 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6399116A4CE for ; Wed, 20 Apr 2005 20:34:13 +0000 (GMT) Received: from imf22aec.mail.bellsouth.net (imf22aec.mail.bellsouth.net [205.152.59.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id C326C43D5C for ; Wed, 20 Apr 2005 20:34:07 +0000 (GMT) (envelope-from ahze@ahze.net) Received: from [192.168.1.5] ([68.209.163.3]) by imf22aec.mail.bellsouth.netESMTP <20050420203407.OIFM2068.imf22aec.mail.bellsouth.net@[192.168.1.5]>; Wed, 20 Apr 2005 16:34:07 -0400 Message-ID: <4266BCBA.2070406@ahze.net> Date: Wed, 20 Apr 2005 16:34:02 -0400 From: Michael Johnson User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jeremy Messenger References: <20050420194825.76ebf3c0.flynn@energyhq.es.eu.org> <20050420203250.597f6ae8.flynn@energyhq.es.eu.org> In-Reply-To: X-Enigmail-Version: 0.89.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDA849FB797E848A7CBBA8062" cc: gnome@freebsd.org Subject: Re: Can somebody please have a look at ports/78931? X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2005 20:34:13 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDA849FB797E848A7CBBA8062 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Jeremy Messenger wrote: > On Wed, 20 Apr 2005 13:32:50 -0500, Miguel Mendez > wrote: > >> On Wed, 20 Apr 2005 13:11:56 -0500 >> "Jeremy Messenger" wrote: >> >>> Not useful to me, but it's up to someone in my team if he likes OPTIONS >>> stuff. Anyway, I took a bit look at it and I don't think few knobs will >> >> >> Could you elaborate on why you don't think OPTIONS are useful? I'm >> honestly interested. >> >>> work because of the OPTIONS don't work with the autocheck very well. I >>> only see useful in your PR is that two knobs that have exist() should be >>> move under .include and change DATADIR in plist. >> >> >> I did test builds with BATCH=yes and it worked fine. If there's >> anything wrong I'd love to know about it. > > > Nevermind, I thought the RSVG2 has '.if ${HAVE_GNOME:Mlibrsvg2}!=""'.. > The bsd.gnome.mk doesn't work with OPTIONS yet. > >> To make it clear: Whether the >> consensus is to get it in the tree or drop it, it's fine. What I'd like >> to avoid is to have the PR sitting in limbo for months. > > > If nobody touch this PR for two more weeks or more maybe in May, then I > will taking and commit it w/out add OPTIONS stuff then close it. That > should give my team plenty of time if they want to add OPTIONS or make > any comment on it. Personally I don't like the idea of OPTIONS in gimp, well atleast not all of them ie. WITHOUT_JPEG, who is really going to use that OPTION. Michael > > Cheers, > Mezz > >> Cheers, > > > --------------enigDA849FB797E848A7CBBA8062 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCZry6n4uqfTwEb9YRAkI8AJ43B4IUCFbj7RbJQkuiQrzB/THOyACgvGbu urRgaKZljDCZcv6lnk+IZ14= =URTC -----END PGP SIGNATURE----- --------------enigDA849FB797E848A7CBBA8062--