From owner-freebsd-mips@freebsd.org Thu Jan 28 02:24:46 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E34E4A6FFAC; Thu, 28 Jan 2016 02:24:45 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0130.outbound.protection.outlook.com [157.56.111.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BA6D111B; Thu, 28 Jan 2016 02:24:44 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from BY1PR0501CA0036.namprd05.prod.outlook.com (10.162.139.46) by CY1PR0501MB1385.namprd05.prod.outlook.com (10.160.148.139) with Microsoft SMTP Server (TLS) id 15.1.390.13; Thu, 28 Jan 2016 02:09:13 +0000 Received: from BN1AFFO11FD017.protection.gbl (2a01:111:f400:7c10::171) by BY1PR0501CA0036.outlook.office365.com (2a01:111:e400:4821::46) with Microsoft SMTP Server (TLS) id 15.1.390.13 via Frontend Transport; Thu, 28 Jan 2016 02:09:13 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=juniper.net; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BN1AFFO11FD017.mail.protection.outlook.com (10.58.52.77) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Thu, 28 Jan 2016 02:09:12 +0000 Received: from stevek-ubuntu.jnpr.net (172.25.4.171) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.123.3; Wed, 27 Jan 2016 18:09:11 -0800 Date: Wed, 27 Jan 2016 21:08:51 -0500 From: Steve Kiernan To: Warner Losh CC: Stanislav Galabov , , Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c Message-ID: <20160127210851.5c64c580@stevek-ubuntu.jnpr.net> In-Reply-To: <55D21A1C-E1E3-4800-8069-8EA98A8F85A0@bsdimp.com> References: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> <20160127192015.64d0ded0@stevek-ubuntu.jnpr.net> <55D21A1C-E1E3-4800-8069-8EA98A8F85A0@bsdimp.com> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/njIM=mqhvIuzFh.n=y7DiAk"; protocol="application/pgp-signature" X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD017; 1:0KohyemSHiiGvz7POqfIbZVwMjfBv/+6zACE2A8i7GiCXYzfwEDm5afZ5KKu2AzDrGYF1TwzieSGCEOnrprkMO7c6NmwxtbVwOMlOyVIAbs9+B+2W956vsjPAAMg+VkILbmeHxNNIbgcpf5TvUJo/fMHu4QhN/NgHnKVDCDdNrmtp9yAHG3fxmuI+yzYWZTDI3QTyEYiCELrGTqzfqHI80LEHaDMqQru/4GxEqmPdbzu5ZLUKIOOEqV7dfPk8yn/99DM5a5vUoJea4DpR8n/v0dZS18nCFFzVVY08oTznGw7Wh/OGZDGZ6uAdUJOqxf83oMCGTPZ3qXrBS3Oi7mgflcJLXqzfQOEh7a34EE7chxbPVWZRLY2WGBRNE0yAB4cjVuZo+rgHqW8KvP+kMoanASqPTRol+xxx5OkpW2ztUE= X-Forefront-Antispam-Report: CIP:66.129.239.19; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(24454002)(377454003)(189002)(199003)(15975445007)(5001960100002)(106466001)(2950100001)(1220700001)(110136002)(104016004)(6806005)(189998001)(11100500001)(77096005)(50986999)(105596002)(97736004)(1096002)(586003)(5008740100001)(3470700001)(76176999)(19580395003)(5003600100002)(81156007)(84326002)(53416004)(512874002)(19580405001)(1076002)(87936001)(4326007)(86362001)(50226001)(92566002)(33646002)(93886004)(69596002)(5890100001)(2906002)(39210200001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0501MB1385; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1385; 2:Y2dtSBE24JK7z/lGhpksrNN801YB7yS1HQVRKVku1nZ6YJEjoyGjkBby38crYpY4Yhfkb6QOoJa6t06dbiE+QU/2Nn15IJQQZ8BsiO+SyGpZVTHNFGCYBRYQiYcrYYyRt8uxc+J5293BOmLPc3nwCA==; 3:T4423V8BHEZnlGT+lJ5AgrgPs95l30aVR+CsJr0DP7gZnObl4Ok3RJkf4gpJN7hXZ6wWn0//ilLBHftJd9YoAd+W8wEOzYFVSaTWwvz5uba8DrtyBDfVJyT7oLZK/M8zlkvBCxnKgdwyPWbMjuWA8RPCtuYLnf4LpQ8BzRIJ5GVdyxIXps5wJtwusIUpvbCZ0HFa3iG1b118T12PncApAFlN2OwFYntAfjf0PHdcoCs=; 25:9k9PPUItp/pJDdbtuX5xK22B2tPOzOKK5kAZ0u3eTiVN9ofZYxpl/mXvAX0UsuZ91krDcXTUuBYtdUVuta/oW4UrnGczNgRhpiryjIOQ65fab2vhIJmLt8N4o3MHzm00jPP/PWdC963trw4utPMg5MqmWEQ9wShPwLf9cZBW3xTzYqJhnAelnrAWgGfyKNCDB9SaiMHDbNSnABjeuZrcTr2QzDGlBDy9cQCaLSRxnZgMewrStCwV4zwGD8oEAyOs X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0501MB1385; X-MS-Office365-Filtering-Correlation-Id: ded927cc-cd26-41f6-1d9d-08d3278803fc X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1385; 20:SeGKQEwkEzvquFtkP0rp6xLzw1SQTHqA5jJxNjPst9beza/jmU7T2X1wgznsAHWR3IXFdKW0JbMyqN6u6MHTGX//bR5OO0SmbpMfbbbRDfkoNKdv6MuTe+gT5b7k1L4s0dgmqB1IWmMTLcmp1g/+Nrm9iZ1lOUapTrFUs5QwmDd29T0pF1O/iAYkzDt/A/QOKhRfvu0BvJmHx4jCODZZKo1u1cH6oojJRHkwEPAwyGTRwb5SgpQtHZIoZtKdL06rsy4OgPfxYbb64LfLbnWJxGxC7tcerIN2MqmI6JdnNVPaHELgxMXAXHLm/svN1TNXLm2K/eTjZZATEA0uMAIkAmKHuYqd70AB7w7n1TbECh/xXJX9BbCxElHOf8SCm4cANGryXoIt1mQd0LuGIWm+xprajh6X7OcHn9gbLPTsoumUAliqpI84ppu3tMTPa59VJHB1HkchvJ+hshP7PHjRl/WWDKwPfDikcBgKfVqmwn9Cn9jq3Uxm26QS7zT+7F4g X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(138986009662008); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(13024025)(5005006)(13023025)(13015025)(13017025)(13018025)(10201501046)(3002001); SRVR:CY1PR0501MB1385; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0501MB1385; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1385; 4:KKwB/808t2HeiC42espwwM4E95Nc37DWfFBUG7FVfZ/F5d72Bt71CBAB8AlGxBz1aUWPpdN0Tu6mYnoi17z3CRlW5nxJUPw3p+fJ7kAGvq/V/AqiK8RmtR/vV3ojLY6Kl06CieeQ5LStfe96nMXDs28X+449x/01Vik/J3f3JDCreDgnlYol2U4r9rovbtq6F/KgkcZx2xmLsggNKywu8fg4NYn54VL3jIaEeBIzIjl4nx4vqq508fEvOqMCH9OUQMYZgEckiYCvPPMzCOXzd9zR8RrMc9ucEPfp42mhgtQQSQigOedBHuTn6Ne4AUvsPorUzxCqioP6vblA1nK8EB1plDuDLBkyOSWiPi/bnf8JlocdtxoG0PLbsjtSXJYKgCUPYMz5n4YsbY0Jb1DLGVSMsIxuFp7zWu73Sb84ZkzyGKto9Hi127CLNF+NEwb0ABAmRkGg136XI7E50ktJFhMTtBU2BelcsQiH4RBOgIcfPvGBSzA/g9+5Wx5O7FOO X-Forefront-PRVS: 083526BF8A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0501MB1385; 23:KzuESEyZHgR9/m4zuQpKeRNP7G9b8hwbF1ErfyB?= =?us-ascii?Q?46DTy5BlRuPdjAYte0WFDSxs4Jz4b1LGccnSpEqXkTGEr3OrRamNt/pFbrCh?= =?us-ascii?Q?iPuKr7y+vxef9umnmTSy5zg19CFYqVPoVa6dqwywT8D7YOP6bZa2/W9iyQ+7?= =?us-ascii?Q?AbEgL2w5nnVVNVz0zuOBdhAMOBJBHrpygZb3C9Gajkgi3AGc6GsIZe1FSqqh?= =?us-ascii?Q?xCIHycUw1bsogPnls6VsGxj3P4ysXawT9HfTRFrmdDl/KQSVi712k3d18+Ce?= =?us-ascii?Q?Ey0XrnLncDpyS+oeC8ol9kofQ9+jqrutwD9shJKIsOOpbcojHXEb+YQHUBnr?= =?us-ascii?Q?7Lp1Phgv5rlQkj9O2QYYxrmZFly9X3gLf+RZxkoM1kUbdsw5lF/6gtWd3Pbr?= =?us-ascii?Q?/z5rHHo+n947704GIawcjclGgQ9TNUZAN7ObKmASabLqmahZ0LE3P64gAE8M?= =?us-ascii?Q?OyAMZhAGOHdtY2gz372VDeORurbNIQNe6/z6evdtsvEXdxRSh+I+aX7u+/gf?= =?us-ascii?Q?c55dp/XhdvrudGQ2ANnnixcreuMg6yanA4pg1rHRAIqxz4h73nYIOeforTaN?= =?us-ascii?Q?m/gn8Dh+/s9q5cxgDYSuSnLOpkknzqM34rL/3T8gHjuAigwxI9mDx0riKsfR?= =?us-ascii?Q?LqvXsI/fNDvgxo46AuVjteIZ0Hjnt9QMMD70bLmkYGDDj9dY5Njz1ZnMIfwr?= =?us-ascii?Q?wL1CAYtaSgUch4yetsWJUKVowpz7z4TI7YyOKfW59xnwvy5zw//T8YUgmCvL?= =?us-ascii?Q?PgPsV8ixqUEVbfs/J5lnXryyG5e5a+rwqJdY0G+ADFV2i+AQkE8vO3fI4LMN?= =?us-ascii?Q?yWnXGZv5ztc80iQGHxZosmwUkZKXC2X6LGdRup6xijW7r8RVTzNDUoZUZauU?= =?us-ascii?Q?pq0hYdjtdVL7wYLPJRzgKxX8PSYnlDB1SPEjte8tWEwesKwzfi7F933Ru8xB?= =?us-ascii?Q?OTjiN3he//z3gLaquzMHXX9PfxdDgxutK4dclB2gM8/Wy03aq5MPABT/j/OX?= =?us-ascii?Q?c+Zw9MMPK0iJXA6681DXqpY+bKWJND4PSlyXb8N9zeej7mNanhTvjsROuhOl?= =?us-ascii?Q?uY0jahoMwq530k5T7gZEhCp731KWPlZ6YS5QTVSh//3CfCnQHYDegIqn6f5n?= =?us-ascii?Q?JB2VTwEikiKBLg7WtqHK3QhZLKuuCN0Euk9YYfYGRO2g8V0dNAIZn/Q=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1385; 5:Egf6hOUiwCfNrM1EW0/1IJc8wDO2kEnO9tGwoCFLJ7eDR0ExtVb3jx/e42iuaP5Tq0yeraGl4wK/CfQwBL+QFmlKgQXzuPXpmKQml40BfVfvX69L353nsdA4EGR/HT3IkAWDNStNJ1jTJNz4uEAeNw==; 24:7KhnuyRzq53f3ePlUSzDcX9lT1+DtykqZl+Nh5cDSVHzWCpZs8+aK8Qy4HbT1/gjHMpGwUf59iNDuiJotJsNT0Ra3zeaSlR7vvx8BTYBU8E= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2016 02:09:12.1830 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0501MB1385 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 02:24:46 -0000 --Sig_/njIM=mqhvIuzFh.n=y7DiAk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 27 Jan 2016 18:11:24 -0700 Warner Losh wrote: >=20 > > On Jan 27, 2016, at 5:20 PM, Steve Kiernan wrote: > >=20 > > On Sat, 23 Jan 2016 07:18:04 +0200 > > Stanislav Galabov wrote: > >=20 > >> It looks like only part of the original patch I submitted made it into= head > >> (only the mx25l part). > >> We also need to change sys/conf/files as Steve pointed out, as well as > >> sys/geom/geom_flashmap.c: > >> https://bz-attachments.freebsd.org/attachment.cgi?id=3D165546 > >=20 > > One other thing that needs to be considered. The nand driver has an ioc= tl > > for getting chip parameters (see chip_param_io structure in > > sys/dev/nand/nand_dev.h) and geom_flashmap only allows for > > NAND_IO_GET_CHIP_PARAM to be passed to the provider. However, the CFI a= nd > > SPI devices do not implement this and they probably should not as-is. > > Something more generic to flash devices that are handled by geom_flashm= ap > > is probably in order. >=20 > The different chip parameters shouldn=E2=80=99t be done through an ioctl = with geom. > It should be done with geom attributes. We should implement a sensible se= t for > all three and have geom_flashmap use those instead of the ioctl. geom_flashmap doesn't seem to be using it itself, it's only using the geom attributes NAND::device, CFI::device, or SPI::device. It's just filtering the ioctls to only allow NAND_IO_GET_CHIP_PARAM to get passed up to the provider. However, I agree that there should be a sensible set to the get the chip parameters, as the one thing missing from geom_flashmap is properly restricting the slicing to be aligned to flash block requirements and ensuring the slice is not larger than the size of the device. -Steve --Sig_/njIM=mqhvIuzFh.n=y7DiAk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlapeDMACgkQZSuJlLuTi6iVbgCgsx6eP0hZ/aJD0+zldTDji3+t /1gAoKCpKyG9ydyOTLPHZo8RyMoEO1sQ =yAbi -----END PGP SIGNATURE----- --Sig_/njIM=mqhvIuzFh.n=y7DiAk--