From owner-freebsd-net@FreeBSD.ORG  Sat Jun 11 12:05:09 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@FreeBSD.org
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33BC516A41C;
	Sat, 11 Jun 2005 12:05:09 +0000 (GMT)
	(envelope-from maxim@FreeBSD.org)
Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7DDC243D1D;
	Sat, 11 Jun 2005 12:05:08 +0000 (GMT)
	(envelope-from maxim@FreeBSD.org)
Received-SPF: pass (mp2.macomnet.net: domain of maxim@FreeBSD.org designates
	127.0.0.1 as permitted sender) receiver=mp2.macomnet.net;
	client_ip=127.0.0.1; envelope-from=maxim@FreeBSD.org; 
Received: from localhost (localhost [127.0.0.1])
	by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id j5BC56EM005783;
	Sat, 11 Jun 2005 16:05:07 +0400 (MSD)
	(envelope-from maxim@FreeBSD.org)
Date: Sat, 11 Jun 2005 16:05:06 +0400 (MSD)
From: Maxim Konovalov <maxim@FreeBSD.org>
To: Igor Sysoev <is@rambler-co.ru>
In-Reply-To: <20050611020140.R27835@is.park.rambler.ru>
Message-ID: <20050611160250.K5756@mp2.macomnet.net>
References: <20050611020140.R27835@is.park.rambler.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: freebsd-net@FreeBSD.org, Alfred Perlstein <alfred@FreeBSD.org>
Subject: Re: setsockopt() can not remove the accept filter
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Jun 2005 12:05:09 -0000

Igor,

On Sat, 11 Jun 2005, 02:12+0400, Igor Sysoev wrote:

> Hi,
>
> man setsockopt(2) states that "passing in an optval of NULL will remove
> the filter", however, setsockopt() always return EINVAL in this case,
> because do_setopt_accept_filter() removes the filter if sopt == NULL, but
> not if sopt->val == NULL.  The fix is easy:
>
> -        if (sopt == NULL) {
> +        if (sopt == NULL || sopt->val == NULL) {

I committed fixes for this and related bug and will MFC them in two
weeks.  Thanks!

-- 
Maxim Konovalov