Date: Fri, 08 May 2015 19:13:31 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file Message-ID: <554CFCCB.8070800@FreeBSD.org> In-Reply-To: <554CDBE8.7020703@FreeBSD.org> References: <201505081305.t48D5ULi055835@svn.freebsd.org> <CAMHz58SAcjiCprFNT_x0xgg6ceBzhh0s%2BBgYj1uo%2BDQ96rVEyA@mail.gmail.com> <554CD6C9.5000708@FreeBSD.org> <CAMHz58Qk1RfOfh%2BrfaJoFVz5%2B5ij3BxmQQ1a87c2nCtp%2BoBZyA@mail.gmail.com> <554CDBE8.7020703@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IP3E75A82wLd6HfBDNSlgRsIPLvciTJf0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015/05/08 16:53, Bryan Drewery wrote: > On 5/8/2015 10:43 AM, Sunpoet Po-Chuan Hsieh wrote: >> On Fri, May 8, 2015 at 11:31 PM, Bryan Drewery <bdrewery@freebsd.org >> <mailto:bdrewery@freebsd.org>> wrote: >> >> On 5/8/2015 9:45 AM, Sunpoet Po-Chuan Hsieh wrote: >> > On Fri, May 8, 2015 at 9:05 PM, Matthew Seaman <matthew@freebsd.= org <mailto:matthew@freebsd.org> >> > <mailto:matthew@freebsd.org <mailto:matthew@freebsd.org>>> wrote= : >> > >> > Author: matthew >> > Date: Fri May 8 13:05:29 2015 >> > New Revision: 385776 >> > URL: https://svnweb.freebsd.org/changeset/ports/385776 >> > >> > Log: >> > A data backend for Hiera that can return the content of >> whole files. >> > >> > WWW: https://github.com/adrienthebo/hiera-file >> > >> > Added: >> > head/sysutils/rubygem-hiera-file/ >> > head/sysutils/rubygem-hiera-file/Makefile (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/distinfo (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/pkg-descr (contents, >> props changed) >> > Modified: >> > head/sysutils/Makefile >> > >> > Modified: head/sysutils/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- head/sysutils/Makefile Fri May 8 13:02:39 2015 >> > (r385775) >> > +++ head/sysutils/Makefile Fri May 8 13:05:29 2015 >> > (r385776) >> > @@ -836,6 +836,7 @@ >> > SUBDIR +=3D rubygem-hammer_cli_foreman_salt >> > SUBDIR +=3D rubygem-hammer_cli_foreman_ssh >> > SUBDIR +=3D rubygem-hiera >> > + SUBDIR +=3D rubygem-hiera-file >> > SUBDIR +=3D rubygem-librarian-puppet >> > SUBDIR +=3D rubygem-log4r >> > SUBDIR +=3D rubygem-logify >> > >> > Added: head/sysutils/rubygem-hiera-file/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- /dev/null 00:00:00 1970 (empty, because file is newl= y >> added) >> > +++ head/sysutils/rubygem-hiera-file/Makefile Fri May 8 >> 13:05:29 >> > 2015 (r385776) >> > @@ -0,0 +1,18 @@ >> > +# Created by: Matthew Seaman <matthew@FreeBSD.org> >> > +# $FreeBSD$ >> > + >> > +PORTNAME=3D hiera-file >> > +PORTVERSION=3D 1.1.1 >> > +CATEGORIES=3D sysutils rubygems >> > +MASTER_SITES=3D RG >> > + >> > +MAINTAINER=3D matthew@FreeBSD.org >> > +COMMENT=3D Data backend for Hiera that returns whole = files >> > + >> > +USE_RUBY=3D yes >> > +USE_RUBYGEMS=3D yes >> > +RUBYGEM_AUTOPLIST=3D yes >> > + >> > +RUN_DEPENDS=3D >> > ${PKGNAMEPREFIX}hiera>=3D0:${PORTSDIR}/sysutils/rubygem-hie= ra >> > >> > >> > RUN_DEPENDS should appear earlier. :) >> > >> >> Why? >> >> >> % portlint -abct >> WARN: Makefile: Consider defining LICENSE. >> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. >> 0 fatal errors and 2 warnings found. >=20 > This rule serves no purpose. The port was pretty much cut'n'paste from sysutils/rubygem-hiera. Besides, where in the Makefile would be considered suitable by portlint? Above all the USE_FOO=3D stuff? That's going to generate even worse complaints. Oh, I get it. It thinks the RUBYGEM_AUTOPLIST line should occur later. Except that the rational place to put that is right next to the 'USE_RUBYGEMS' line. portlint isn't guarranteed to be perfect, and in this case, I think it is complaining unnecessarily. Cheers, Matthew --IP3E75A82wLd6HfBDNSlgRsIPLvciTJf0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org iQJ8BAEBCgBmBQJVTPzMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxOUYxNTRFQ0JGMTEyRTUwNTQ0RTNGMzAw MDUxM0YxMEUwQTlFNEU3AAoJEABRPxDgqeTnxPkP/0zXnM02ESWzSZITyQaTX1Q2 AmP0womy7kbP6fyrx3uKJx2D2ugh1vLR13j6NPz33+YdBesTvhtpxK8f0uNsTvyx PutB0eO1pPu0DcKgjg5Pc2+H2gDU5yQh4HtfvWsEsHsk52RdKrJ31aw47Eap14n+ LXU4gvwLfx02zAf6Sz18khj6cecMfhepOwvMNoX67r6ANV+iU/OUhhSQSieS6dD8 331srWO6eAL24a8pNvYju7gBVGGrC/O5UYcoqaqvOfd1FkEWcN6OdNglZQ1wWBVC OPSEMBa7k7V2STnWWrkAYv03F1vzEAwZzeyERkXSO9u6H2v3LbXXu/JG1URyt41z pQ0XrNnB37bX9wcYHRamwW4ew09Br6HcYYAhZc+3S25A+ul03wANIT5QDLBf+K26 GHm6Tk+fPhVj8ZBUmhVn1U+R1UXOe48sg7A5eSYPLi4wguMW+b/sZ/t/v+HDlRqf B38Nop4J1boL9kWd2oItFL2erEfXIAjI2Pah2ozhrYy7BAoyZdNVuq8JAPkRN1uZ lLp15/Iv2tF+NlHtINIhue2DVztof+fX355p7DDXWPVgJ2m9fGNKAJntU+Af3tvf VbHrVMbkzPNl3wRFGj4qsQPdUqpDw2hLW3YGr/8v1s8QyjFuRuU680rUdmqSb3w4 0ftqbYTiQ/HT07QgGgOl =TqF4 -----END PGP SIGNATURE----- --IP3E75A82wLd6HfBDNSlgRsIPLvciTJf0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?554CFCCB.8070800>