From owner-svn-ports-all@FreeBSD.ORG Mon Feb 25 05:51:15 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 47DBF7E6; Mon, 25 Feb 2013 05:51:15 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by mx1.freebsd.org (Postfix) with ESMTP id 1B9A7EAE; Mon, 25 Feb 2013 05:51:13 +0000 (UTC) Received: by mail-wg0-f51.google.com with SMTP id 8so2052148wgl.6 for ; Sun, 24 Feb 2013 21:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=d0D8fdy5jF1bEWfuaqaozryz6gkABoTRcsjqwYxrp28=; b=qf4Lc5ufralNWDY2K/TdfTw5askC+3NsruLqv0n2cxvb7227jFBPI9+natNVBZ1Got uuyYlWKPnxaNLcfzpBCewK1H49HKQY5gapTSDU/NgRTrie7lQU5HqAAoF/AbaWRttZUL +o2gN+crKftzcOw9tVA4PZ7t+oqf/aLYp87X9xeMC1IGfWudm1VThG6qw1dQHQqw3Age JztgyBpEw4aS0yYwU6+gs+cVfVO1byfeDQK0C2vwXkmJQnKDqVd5mXReAsskRQMnxExF Y+BoY6wOPxqGggpfL1gLU4BK6Xy3Ox57sc0UuR4ozI1t4RmbCyLEkpvH7RaAA6tVG7GJ OzBw== MIME-Version: 1.0 X-Received: by 10.181.11.198 with SMTP id ek6mr10344348wid.1.1361771467236; Sun, 24 Feb 2013 21:51:07 -0800 (PST) Received: by 10.180.81.4 with HTTP; Sun, 24 Feb 2013 21:51:07 -0800 (PST) In-Reply-To: <512AF924.40504@yandex.ru> References: <201302250425.r1P4Pc9u020378@svn.freebsd.org> <512AF924.40504@yandex.ru> Date: Mon, 25 Feb 2013 13:51:07 +0800 Message-ID: Subject: Re: svn commit: r312904 - head/net-im/imspector From: Marcelo Araujo To: Ruslan Makhmatkhanov Content-Type: text/plain; charset=KOI8-R X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Po-Chien Lin , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: araujo@FreeBSD.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2013 05:51:15 -0000 2013/2/25 Ruslan Makhmatkhanov > Hi, > > Marcelo Araujo wrote on 25.02.2013 08:35: > > 2013/2/25 Po-Chien Lin >> >> Author: pclin >>> Date: Mon Feb 25 04:25:37 2013 >>> New Revision: 312904 >>> URL: http://svnweb.freebsd.org/**changeset/ports/312904 >>> >>> Log: >>> - Add IPFW suuport [1] and enable it by default [2] >>> - Trim Makefile header [2] >>> - Remove invalid entry from MASTER_SITES >>> - Patch to fix clang compiling >>> - Tune pkg-plist to pet portlint(1) >>> >>> PR: ports/175765 >>> Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1] >>> Approved by: Mikhail Tsatsenko (maintainer) >>> [2] >>> Approved by: swills (mentor) >>> >>> >>> Dear Po-Chien, >> >> For my eyes, it is pretty much strange when we have two lines of "Approved >> by" or more then one line of Submitted by or wherever, usually we use only >> one line, and something like bellow: >> >> Approve by: Mikhail Tsatsenko (maintainer) >> swills (mentor) >> >> An example to submit: >> >> PR: ports/1111 [1], ports/22222 [2], ports/33333 [3] >> > > Will this line be expanded up to three gnats followups (with commit > message) for three different pr's? > If I recall correctly it was suggested to use exactly this form to make > sure everything is right: > > PR: ports/1111 [1] > PR: ports/22222 [2] > PR: ports/33333 [3] > > And I stick this style because of that reason. Can anybody clarify (once > again)? > > Yes, would be great if we have more comments, because in the section 16.3 of committers guid[1] does not mention nothing about it. [1] http://www.freebsd.org/doc/en/articles/committers-guide/article.html Best Regards, -- Marcelo Araujo araujo@FreeBSD.org