From owner-freebsd-bugs@FreeBSD.ORG  Sun Jul 13 16:54:40 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51FA7106567D;
	Sun, 13 Jul 2008 16:54:40 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3216D8FC0A;
	Sun, 13 Jul 2008 16:54:40 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from freefall.freebsd.org (rwatson@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6DGseZ5082105;
	Sun, 13 Jul 2008 16:54:40 GMT
	(envelope-from rwatson@freefall.freebsd.org)
Received: (from rwatson@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6DGseI7082101;
	Sun, 13 Jul 2008 16:54:40 GMT (envelope-from rwatson)
Date: Sun, 13 Jul 2008 16:54:40 GMT
Message-Id: <200807131654.m6DGseI7082101@freefall.freebsd.org>
To: iusty@k1024.org, rwatson@FreeBSD.org, freebsd-bugs@FreeBSD.org,
	rwatson@FreeBSD.org
From: rwatson@FreeBSD.org
Cc: 
Subject: Re: misc/125575: acl_valid() has wrong checks
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2008 16:54:40 -0000

Synopsis: acl_valid() has wrong checks

State-Changed-From-To: open->analyzed
State-Changed-By: rwatson
State-Changed-When: Sun Jul 13 16:53:23 UTC 2008
State-Changed-Why: 
I've reproduced this bug using libc on FreeBSD 7.0 and 8.x using
Iustin's test program:

#include <sys/types.h>
#include <sys/acl.h>
#include <stdio.h>
#include <unistd.h>
#include <sys/types.h>

int main() {
        acl_t ma;
        acl_entry_t e;
        uid_t user=getuid();

        ma = acl_from_text("u::rw,g::r,o::-");
        if(ma==NULL)
                perror("acl_from_text");
        if(acl_valid(ma)==-1)
                perror("initial acl is not valid");
        if(acl_create_entry(&ma, &e)==-1)
                perror("acl_create_entry");
        if(acl_set_tag_type(e, ACL_USER)==-1)
                perror("acl_set_tag_type");
        if(acl_set_qualifier(e, &user)==-1)
                perror("acl_set_qualifier");
        if(acl_calc_mask(&ma)==-1)
                perror("acl_calc_mask");
        if(acl_valid(ma)==-1)
                perror("modified acl is not valid");
}



Responsible-Changed-From-To: freebsd-bugs->rwatson
Responsible-Changed-By: rwatson
Responsible-Changed-When: Sun Jul 13 16:53:23 UTC 2008
Responsible-Changed-Why: 
Grab ownership of this PR since I wrote the code in question.

http://www.freebsd.org/cgi/query-pr.cgi?pr=125575