From owner-svn-ports-all@freebsd.org Fri Oct 12 19:03:33 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55F2E10C757D for ; Fri, 12 Oct 2018 19:03:33 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc34.google.com (mail-yw1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E1A77713D8 for ; Fri, 12 Oct 2018 19:03:32 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc34.google.com with SMTP id 135-v6so5338556ywo.8 for ; Fri, 12 Oct 2018 12:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nDxhTed50OE7mHpumji7PiHqT/JOMmIHB6Sbv1Y1VWk=; b=H0t7cYAsSOLp2IpaHXm2GeEH9J7tM5QLxyY0vZuZVfiDuf/2HKKK1sLTfH3S2XT38V uE+DrC8tiB+mST2/YSZvvo+REPJzzdOW50b3gAN/X0/5R+jYtFrEiF/7mUmjdxl61bae iyLu5ykdxYsJqnh5qj2LQXa1t1LC3deQilg4uNdi56UYc2LIb4bqlBBb/iomuURmYP2o p/pZEjQvKg+4Eegi3f47g4To4ko5+u+t7ISWvtFun5TR2UFTqeUU0JIH6ybRTXsOC7qf qi0uvGO79hoyckSVZ3vi87cuDswxKD+zvOqblcGJD/umJWFexuFqUqIa4QdKknMJhR6y 8PgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nDxhTed50OE7mHpumji7PiHqT/JOMmIHB6Sbv1Y1VWk=; b=pN+VbFWY+5VVYYFGglyahIIJngJeG8ELTyFeqmbDQozPZ1nUb38pSa2Gp+pb5MzpUl Fg8Qn5aulZZcWMPO/XdhIzt9z8sdGFJMqrkhjVN54jb0mkYow7EIS4F5SgAyJgkPXKRe 3AXtdq3StNwgYZItpPDHdeBiu9dtZs9WxZnkP2CrkiTFG21IvftS2x4YYyvtM6V9kkIN cXOu8jBQeLtYcSLQUkUdT/ThOZcBnzqBwMRZmBXFzxKR0u4DixMkwh8Io+rOTGIHe0z9 YL9TauEZ2GfX0mpMF//I1q44me0bbfylyDJANIKJtMfK2tmOxnp06rXkcDOXvAmbrvsW 2CtQ== X-Gm-Message-State: ABuFfohDqc4axh6el9RN/O+jF7aIV0U6ur0IwVGGBaOFxXZV6YgMhEdl pZFPSgkM93kneh7AJtp6GZCCC3Ci2ijl/7pgDHGLgA== X-Google-Smtp-Source: ACcGV63J4yZ0E45zXiutChztal4/p2yHRJK1bIM5ttstMdkXUjLT1dwYzb2v0Ge+5KTXYQagS/9TvkVVl2nleyIIHEw= X-Received: by 2002:a81:5055:: with SMTP id e82-v6mr4241908ywb.232.1539371012086; Fri, 12 Oct 2018 12:03:32 -0700 (PDT) MIME-Version: 1.0 References: <201810061306.w96D6jJe040138@repo.freebsd.org> <20181012174130.GF79805@hades.panopticon> In-Reply-To: <20181012174130.GF79805@hades.panopticon> From: Adam Weinberger Date: Fri, 12 Oct 2018 13:03:16 -0600 Message-ID: Subject: Re: svn commit: r481365 - in head: archivers/p5-Archive-Any archivers/p5-Archive-Any-Plugin-Rar archivers/p5-Archive-Extract-Libarchive archivers/p5-Archive-Peek archivers/p5-Archive-Rar archivers/p5-A... To: amdmi3@amdmi3.ru Cc: des@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, portmgr@freebsd.org, perl@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 19:03:33 -0000 On Fri, Oct 12, 2018 at 11:50 AM Dmitry Marakasov wrote: > > * Dag-Erling Sm=C3=B8rgrav (des@FreeBSD.org) wrote: > > > Author: des > > Date: Sat Oct 6 13:06:42 2018 > > New Revision: 481365 > > URL: https://svnweb.freebsd.org/changeset/ports/481365 > > > > Log: > > Fix every instance of RUN_DEPENDS:=3D${BUILD_DEPENDS} in p5 ports, ex= cept > > for where it resulted in a change in output from build-depends-list o= r > > run-depends-list. > > > > Approved by: portmgr (adamw) > > What exactly is this `fixing'? This is explicitly stated in PHB 5.9.2 as > wrong: > > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.htm= l#makefile-run_depends > > > -BUILD_DEPENDS=3D p5-Object-Tiny>=3D0:devel/p5-Object-Tiny > > -RUN_DEPENDS:=3D ${BUILD_DEPENDS} > > +BUILD_DEPENDS=3D ${RUN_DEPENDS} > > +RUN_DEPENDS=3D p5-Object-Tiny>=3D0:devel/p5-Object-Tiny > > After this change, if something is added to RUN_DEPENDS, it'll end up in > BUILD_DEPENDS as well. This already leads to perl being mentioned in > BUILD_DEPENDS twice. > > Here's another example: > > % grep nmap /usr/ports/net-mgmt/p5-FusionInventory-Agent/Makefile > NETDISC_RUN_DEPENDS=3D nmap:security/nmap \ > > The intent is clearly for nmap to be added to run depends only. But: > > % WITH=3DNETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V = RUN_DEPENDS | grep -o ' nmap' > nmap > % WITH=3DNETDISC make -C /usr/ports/net-mgmt/p5-FusionInventory-Agent -V = BUILD_DEPENDS | grep -o ' nmap' > nmap > > -- > Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D > amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 With all credit to des, I'll give you how he explained it to me. While it isn't better in every circumstance, it is definitely better more often than it's worse. If there were instances where the change brought in incorrect dependencies, those should definitely be repaired (and please, do fix them!). <