Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Jan 2022 14:43:01 +0100
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Dmitry Marakasov <amdmi3@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 74615207da3d - main - audio/wavplay: fix ONLY_FOR_ARCHS
Message-ID:  <Yd7a5fB3iFOVz72z@KGPE-D16>
In-Reply-To: <202201121250.20CCojGJ020504@gitrepo.freebsd.org>
References:  <202201121250.20CCojGJ020504@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--BoxYB0hbPiUuBm/k
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

this is wrong. If there is endianness issue, why is powerpc64le removed?

Either the issue is something else (and ONLY_FOR_ARCHS_REASON needs to be f=
ixed) or powerpc64le should be readded.

On 22-01-12 12:50:45, Dmitry Marakasov wrote:
> The branch main has been updated by amdmi3:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D74615207da3d4e9b707ef571=
3256456bcd19d6c3
>=20
> commit 74615207da3d4e9b707ef5713256456bcd19d6c3
> Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> AuthorDate: 2022-01-12 11:02:38 +0000
> Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
> CommitDate: 2022-01-12 12:44:23 +0000
>=20
>     audio/wavplay: fix ONLY_FOR_ARCHS
>    =20
>     - Remove powerpc* from ONLY_FOR_ARCHS, which were incorrectly added
>       on a sole basis that the port builds. It needs to be runtested.
>     - Add ONLY_FOR_ARCHS_REASON to prevent such mistake in future.
>    =20
>     PR:             261061
> ---
>  audio/wavplay/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/audio/wavplay/Makefile b/audio/wavplay/Makefile
> index bfc5c7a82577..d16999356e4d 100644
> --- a/audio/wavplay/Makefile
> +++ b/audio/wavplay/Makefile
> @@ -12,7 +12,8 @@ COMMENT=3D	Wav player and recorder
>  LICENSE=3D	GPLv2 # only
>  LICENSE_FILE=3D	${WRKSRC}/COPYING
> =20
> -ONLY_FOR_ARCHS=3D	amd64 armv6 armv7 i386 powerpc64 powerpc64le
> +ONLY_FOR_ARCHS=3D	amd64 armv6 armv7 i386
> +ONLY_FOR_ARCHS_REASON=3D	does not play sound correctly due to endian iss=
ues
> =20
>  CFLAGS+=3D	-D_WANT_SEMUN
> =20

--BoxYB0hbPiUuBm/k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmHe2uUACgkQelmbhSCD
nJ3Tlw/8DgIEcehgEFoiezo3vjp/ZY46sNVdpq7EVTrxE4QwE3YdCjY7w8n8/Y3O
AzgIdeVcv3vtA8YKzNhYli+Lpj5FEY019T1U/7PrBTutLZFN9yJ11S5cfVyo0cSK
0Ju7BOhkNGt6Ig8y0ah6m5yh3hSoFva/lgx1fCwFdKnhB0P8yNzmtSiaHvNXM2uH
27kLY2F+0j3GXZtLb5kYu7E/4fwE+cQjjtsSLqPaD0OcIKjrOy6vzRluBqlrspcH
YcpwvJEKD1fMhUte2dbHqdjXi+l8E7LIj9qfmp2o0tEIE5BrrWa8lXWiejssPOZX
epDbSvlv+2650C/sl/+00WFoz/94dbj2UhCfKrNMxTBGMmF/I0MfeFDbX9hZMYyw
9UmQ07fPeZxKhdrRKlnsHehXcDclrZWHyuY8LOkUjtI+eykiTKu/R8iG2IT3ooom
elSdlLFt+YM68HMw28up8kYx5an+96+4nYdwWIlFJ4yP+qrdlnkcyLTfmB/F7EyM
7HTwSHZYy7i4Yos4RjbLN5EbC2FALKn0PdT5T7qdvHTZm3PQ2dAMJX6BIvm7sYn5
EETHp/FcismyxEYDmqnutR9ZssPy/MD1VhHZihrbld1Pb3N0pVazl+t8yPnHumNg
9fR+2eijsSWoYcRNVNY/wu/6IbsOfpOLSM+F+P0P0irRgyrHmhI=
=rJ2k
-----END PGP SIGNATURE-----

--BoxYB0hbPiUuBm/k--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yd7a5fB3iFOVz72z>