From nobody Sat Nov 4 12:35:28 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SMxsv0ybDz50HBH for ; Sat, 4 Nov 2023 12:35:47 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-54.consmr.mail.gq1.yahoo.com (sonic315-54.consmr.mail.gq1.yahoo.com [98.137.65.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SMxst5qRfz3gfL for ; Sat, 4 Nov 2023 12:35:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1699101344; bh=gyzcHUyoBera6u4UlTwpogt6Uyrj5Bcc/whH7L1Lof0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=B1Pqjb6Uf+Ox0B2HgcGJgPjk++qsdi30gnV+pZBKwvRcUCzyELD7OkuQ1bdj3b5ACRE2imsN/zA3FKLOeXxVH0WjmSiVPBZRvD9aVfDm2KAlq/G5lKacXFwO+GQ4pYtCs6YuD0h0TZTZxfX7WWC6KLRJhyPbRPt3Wc4bHJlUQwGYoggwgOR+ncx58esFpWfwTziMfA14UCb8KGzavJyumpFiUHHfAXV4Ptlx3burmPELqO0yZ8nFgUlQQk7xgaLcSeeho8YIQU8uXoTYYH5oQ8yYK1OhCzI6MxXugQcZUAM4djGqduvUb3ldjvNEpr9v+2TmpwVolbzknbNtkSqyJw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1699101344; bh=V4Q1zhtdm0ykLg3ALhnTij2axPHjh08JyU2MKgP6eXB=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=GZNHj4LWypiu7FbkzCWRJ8QcovFwdFMj2roXYLpZHueGnfCy/t4/BuEtt2+5GCxfV5U2Wd37kS+SqhsHfoSb500LPrEqjxRpViVd+A56KhSuWMOqUJJMlR2ZN0NizDj5pqlV2rpOkhSdTEEfwOLIeh3g231hbb7gBwp62x+e1nLfJ3nQUGkMFEua4QtCRj8ktjKMDNNnfLoxeyz4WxmCTLXUA8ODmKSCU2q87j6aWzfJNVXqncqN0COEIKvBg4sYDbBWkCKASbO5PDxufM/+egUrLQEcW6NrPqLDkNnzPHAuRozzp5m59x06xvaP+Fb6wyrc0lLS+jKoCwynvviLjw== X-YMail-OSG: scIgLM4VM1mveLq4T_E88xTsWQl5b2Z3O2Lylk27CqeZFv2bXncCs47XXLbYs2r PWKzR9EjbGRxtKwLYRBMdsw0A0GHH0hZebJ6Gx6KjVAaMIiuOdHQBAf2jnJCZ3Q1hKYgvdAU7W1q .1.rEWTdOeqV4qIgCi_vS.f2xDHrW4YtO0gNts654Ow5JSYetNGDCVS1PMIr3f5LhO4nQqqzIZZW 75METUXeubdawPDveHrL5WTng1OyR7Ykb1tLISfCfUP04DVdQJXaUFMH6u1ZITzAM4dmF7XLnabG i9b2o9MmXmwTopr.1oSCblLuldYbhuffHPSyGGwzmHZBM1ha3jmsQckkTlzEui67ZMS8XzMJYd6U IcE7eUP1GBhTvvK1rFVfN6z6Lw3rTRtq3XfEUI1UWm.5Y7ig.a6ViTbIXyUTz84o_D68eWilzR82 Aie4S_7SoIjXblO9nPobcF2ajqpYUY3LT.Rp10jhBIwPFKT.fJOsyGgK1VkySBKttOigdqXovHZy BXUY2F9E9pS5NViC_f_9t9qtkipFSK.QGByvJLc2lcTQ5C6C3MTGVxmdG.uytta_gy1olNdUX16J NXo1mwB44s2KihAIPpONZeDsx._XXx6rPtVWJ_y34ok5jTeddjmyzRzkhetNgp2bFXcqJPZdGF4Z 8HMM5eTkbNTeoLhzNZFHJ5MgOHsFzcUb1XtwatkQvt9i2oj4uk_FZbcMIqp1bPBVttgjtWBN5P7J vPIpMpWdJtQ9bUySobWifzTLG28KXhkMy4CYiI04dapnZQH2xjIMTg9v8iD86V_915fBGhp2DDXV aO99beMv2ulGwUAoQNzOLE2Y5RiSvOevOuevIucoKBibNUIc0ELdUWACaVwLfEwMyRMYLxp0Lv4_ uFDZfKFFFYT0fK5P6T1XNT53t80XbP.8T8wN1Y9469TxUC_zi6TSdZEgTwMUYTVBqs7HBlTcnbvV lwUsy5v0wR7dhUpMZTJG3XyhBogeQo1zACdyPEhBuybm5cfruwN2TwVxKoRvHoeJ7gsorONjuB6l G_Xqx8AAd3IwTV9726n3j78o6OtO4kgbY58DTu3RTnCud4gHmpawbBwt2NH..mPfW0f9N6KUwGp2 g3sBhRWdZIsC.9lzrGY7g.Ar07NXemsjYWBSCwrGR0qqW7bWOWVbyG9naW4HZndpl4IuVPqnVRi_ k3.98w4nlHB4qfwIxm0qGTMC3MJA7iD6NfzTId99wj_60W8723cMejv34EjzJqkWbxuZ6rg.iZSl w09pUYe6IrVM0iNi03CB7tKM6e68XRJWI.JmPiErhodQ.9VBBtWwrGRZriOldW4dUYN05jWfM1Q1 C4T9SpECVQYrAJjeA9lodKPZOBLsh2GrOldjUy3M0kqeWl_ikIZpy_Xl23WhKlOuPGsnYCBHdndV dNxWa4qDU4Dxo1oj4HDBD7jkHVtRMXEM0M3sFW8oIDynY0GlOypmxngKkl_3Us6HQb5Gq4gb5xJl LNo3L4Slvjc6exKY42EtLXVExSJCutwypQhLmFRYfeRzwKZC35_2s1_RrHRE6CQ0EetVA8VjH5hE SAkoT3ZRbopqnmuVudPvocPi3kO.2fU39fhJTu1eGVGcb2SwYvRKI3PWRjuNB.qlwFxOpTBVNqEu po9IbEE2uDSfX5rage5CInsv4lfn35BZc90qL6gjdD6KMGmT8HDu8_3NCYxiQDwqXV6aeIC4K_cD nuQA.44Zg7aKlG38p8sqVHSa1dl_ytb093z4khtUCRrPV7C2qpKqqmTKdmIwUa_K4_gBq1Xev02Y CcuxLv2_QEE8qlIYpk6enXXmKbBpZkxcHkouplJU32i8tHqHMIQaMF9KVdP4j3tUhUKLTDvcfwQI Ux9AtiDN0Q5kawoz_q1bTGz8FruGnhF6hbHRxRzfaSzUjCtaTneXaAZ9k2Hfyrojez57.1uROhSm UqhocUVZLGaRepBZMWodoyCUBivUkYvFzibzGnIdcwAF_dRoBhSMnsMHx3_aUxjmD7E1wE8RnT0y tt8VaFipMIqiUYFmJ1aeFmz621YtU4Cn7Q3ub4_U0RNlRT1br3SW4YXsRA4TGX3S0kLlhG.ip_zp qGyJeHTiMnEbf2cAnj9Ds3_0zmDLQMAwB4d.KpMl2OwnS4ncwOVyVMNZQwSNXZhQvWun9UNHNn1O sOia43ktzzqmKpP51t7I6n6maEmPaIGoZfPeSucGaOwV0q6hikKYUbkj7KgFSTe3DshQgGTm3HZQ tsaNXpwjJOYmfMNSwaU4eAayTCz469z0xJpEB_fhhM3TG60kTXgW5qFB8CPMEjqBfYBig7AWxVvk - X-Sonic-MF: X-Sonic-ID: 7f5a10d3-8499-49c2-acc4-cf4faf831c55 Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 4 Nov 2023 12:35:44 +0000 Received: by hermes--production-gq1-59b5df67b6-gs8xt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0f63790bda9789aa88a377cca8ff4dd2; Sat, 04 Nov 2023 12:35:39 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: Is 14.0 to released based on 0 for sysctl vfs.zfs.bclone_enabled ? From: Mark Millard In-Reply-To: Date: Sat, 4 Nov 2023 05:35:28 -0700 Cc: Ronald Klop , FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <830CD3A8-DB62-418D-A7F7-8DA6CB46B1F5@yahoo.com> References: <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29.ref@yahoo.com> <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29@yahoo.com> <7a906956-6836-421e-b25e-ff701369e3ed@FreeBSD.org> To: Mike Karels X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4SMxst5qRfz3gfL On Nov 4, 2023, at 04:38, Mike Karels wrote: > On 4 Nov 2023, at 4:01, Ronald Klop wrote: >=20 >> On 11/4/23 02:39, Mark Millard wrote: >>> It looks to me like releng/14.0 (as of 14.0-RC4) still has: >>>=20 >>> int zfs_bclone_enabled; >>> SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, >>> &zfs_bclone_enabled, 0, "Enable block cloning"); >>>=20 >>> leaving block cloning effectively disabled by default, no >>> matter what the pool has enabled. >>>=20 >>> https://www.freebsd.org/releases/14.0R/relnotes/ also reports: >>>=20 >>> QUOTE >>> OpenZFS has been upgraded to version 2.2. New features include: >>> =E2=80=A2 >>> block cloning, which allows shallow copies of blocks in file copies. = This is optional, and disabled by default; it can be enabled with sysctl = vfs.zfs.bclone_enabled=3D1. >>> END QUOTE >>>=20 >>=20 >>=20 >> I think this answers your question in the subject. >=20 > I think so too (and I wrote that text). Thanks for the confirmation of the final intent. I believe this makes: QUOTE author Brian Behlendorf 2023-05-25 20:53:08 +0000 committer GitHub 2023-05-25 20:53:08 +0000 commit 91a2325c4a0fbe01d0bf212e44fa9d85017837ce (patch) tree dd01dfce6aeef357ade1775acf18aade535c6271 . . . Update compatibility.d files Add an openzfs-2.2 compatibility file for the next release. Edon-R = support has been enabled for FreeBSD removing the need for different = FreeBSD and Linux files. Symlinks for the -linux and -freebsd names are = created for any scripts expecting that convention. Additionally, a = symlink for ubunutu-22.04 was added. Signed-off-by: Brian Behlendorf = Closes #14833 END QUOTE technically incorrect in that compatibility.d/openzfs-2.2-freebsd should be distinct in content from compatibility.d/openzfs-2.2 so that block cloning would not be enabled. >>> Just curiousity on my part about the default completeness of >>> openzfs-2.2 support, not an objection either way. >>>=20 >>=20 >>=20 >> I haven't seen new issues with block cloning in the last few weeks = mentioned on the mailing lists. All known issues are fixed AFAIK. >> But I can imagine that the risk+effect ratio of data corruption is = seen as a bit too high for a 14.0 release for this particular feature. = That does not diminish the rest of the completeness of openzfs-2.2. >>=20 >> NB: I'm not involved in developing openzfs or the decision making in = the release. Just repeating what I read on the lists. >=20 > There was another block cloning fix in 14.0-RC4; see the commit log. > Maybe there will be no more issues, but it seems that corner cases = were > still being found recently. >>=20 Looks like I'll stay at openzfs-2.1 pool features until there is a release that no longer has the default status: 0 for sysctl vfs.zfs.bclone_enabled I use main [so: 15 now] but only enable openzfs-2.* pool features supported by default on some FreeBSD release, that has an accurate compatibility.d/openzfs-2.*-freebsd file. =3D=3D=3D Mark Millard marklmi at yahoo.com