From owner-freebsd-ports@freebsd.org Tue Oct 4 12:27:13 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEDA4AF4DBD for ; Tue, 4 Oct 2016 12:27:13 +0000 (UTC) (envelope-from rde@tavi.co.uk) Received: from kipling.tavi.co.uk (kipling.tavi.co.uk [81.187.145.130]) by mx1.freebsd.org (Postfix) with ESMTP id 82FDE1CA for ; Tue, 4 Oct 2016 12:27:13 +0000 (UTC) (envelope-from rde@tavi.co.uk) Received: from raksha.tavi.co.uk (raksha.tavi.co.uk [81.187.145.139]) by kipling.tavi.co.uk (Postfix) with ESMTP id F16AD75927 for ; Tue, 4 Oct 2016 13:27:04 +0100 (BST) Date: Tue, 4 Oct 2016 13:27:04 +0100 From: Bob Eager To: freebsd-ports@freebsd.org Subject: Re: LICENSE questions Message-ID: <20161004132704.7a52b810@raksha.tavi.co.uk> In-Reply-To: <614130db-1846-3c97-e94b-7962adc604d0@FreeBSD.org> References: <11cf69da-01ed-e7c3-9c2b-2291e22ab6e9@missouri.edu> <126e66dd-8cee-2475-f44d-193934d1f587@FreeBSD.org> <614130db-1846-3c97-e94b-7962adc604d0@FreeBSD.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; i386-portbld-freebsd10.3) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUwXjFLc0vD0cS7y7zw9PDZ4tkWSRaVrZZ+m39qi2tXfVj////7+/utwK4IPggAOAAJUUA7AAABKklEQVQ4jWPYjQMwDFYJp0NKEKCNJmEf9h8CsimXiL2e33s3/e7F7K2Cs3f3dCMkQkMKj4YuCY3K3iR+e7fMaiSjvkX0/5cFGrWpe2uLzOpaExUVqMS/8PX/Re5ey960OLBTZpFA8+IlSBKPQ92zNyUUBsosN58uIY0k8f+/ONCoYytkVuhWzVwNkYiYbqk5M3NmOVBi41YZ8RsGF7shEtFb5KJ3r969CyixM7OTPeFUxG2IxLO8/9/SvqXlc+/x3h295YzLlj2nIRJQj//nRvc5TEIal8RsXBLVuCQwIgoq/u80DomP6HEOk/iOS+IJLonZOCT+ReOQ+Lkbh0QKLonbOCR+7MYhsRqHBJrVcIl/1TgklqKLQyQ+tGKIgyQOqXpjig94diZRAgAXmDX6jyWafAAAAABJRU5ErkJggg====== MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 12:27:13 -0000 On Tue, 4 Oct 2016 14:15:28 +0200 Mathieu Arnold wrote: > Le 04/10/2016 =E0 14:03, Montgomery-Smith, Stephen a =E9crit : > > On 10/04/2016 06:47 AM, Mathieu Arnold wrote: =20 > >> Le 04/10/2016 =E0 09:29, Eitan Adler a =E9crit : =20 > >>> On 4 October 2016 at 00:25, Mathieu Arnold > >>> wrote: =20 > >>>> Le 04/10/2016 =E0 03:58, Montgomery-Smith, Stephen a =E9crit : =20 > >>>>> Could we use USES=3Dmetaport to suppress these messages? =20 > >>>> Suppress what messages ? =20 > >>> 115 .if defined(LICENSE) > >>> 119 .else > >>> 120 DEV_WARNING+=3D "Please set LICENSE for this port" > >>> 121 .endif =20 > >> Mmmm, this is a warning, not an error, it tells you "dude, maybe > >> you need to do this". > >> I don't see a good reason to complicate the logic more. > >> =20 > > Because naive port maintainers like myself might think they should > > add a LICENSE to any metaport they happen to own. > > > > One of the issues I have with LICENSE is that I don't see anything > > about it in the porters handbook. Otherwise that would be an > > excellent place to tell maintainers of metaports not to license > > them. =20 >=20 > Nobody stepped up to write a LICENSE section. I started writing > https://reviews.freebsd.org/D56 but it is crappy. >=20 > > Also the tone is quite commanding. If it said "Consider setting > > LICENSE for this port", that would be more acceptable. Really, I > > think it should say "Please set LICENSE for this port, unless this > > is a metaport". =20 >=20 > Feel free to make the message better, it is in Mk/bsd.sanity.mk. I believe portlint uses 'Consider'. On the other hand, I had a new port and the committer insisted I had LICENSE in there.