From owner-svn-ports-all@freebsd.org Wed Aug 1 20:35:53 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0663910689A3; Wed, 1 Aug 2018 20:35:53 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B510D86A40; Wed, 1 Aug 2018 20:35:52 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id A6E5E1833D; Wed, 1 Aug 2018 20:35:52 +0000 (UTC) From: Jan Beich To: Alexander Leidinger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476193 - in head/audio/lame: . files References: <201808012001.w71K1Slh060704@repo.freebsd.org> Date: Wed, 01 Aug 2018 22:35:49 +0200 In-Reply-To: <201808012001.w71K1Slh060704@repo.freebsd.org> (Alexander Leidinger's message of "Wed, 1 Aug 2018 20:01:28 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 20:35:53 -0000 Alexander Leidinger writes: > Author: netchild > Date: Wed Aug 1 20:01:27 2018 > New Revision: 476193 > URL: https://svnweb.freebsd.org/changeset/ports/476193 > > Log: > Move patents text from the Makefile to a file. > While I'm here, make it more an explanatory text than just a > copy&paste from the previous comment of the Makefile. > > Requested by: portmgr (mat) [...] > +LICENSE_FILE_PATENTS= $(FILESDIR)/lame_patents.txt $(...) isn't consistent with the rest of the file. $ portlint -C WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE). FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order. FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order. FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+)?/LICENSE_NAME(_\w+)?/LICENSE_TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERMS(_\w+)?/LICENSE_DISTFILES(_\w+)?. 3 fatal errors and 1 warning found. Index: audio/lame/Makefile =================================================================== --- audio/lame/Makefile (revision 476196) +++ audio/lame/Makefile (working copy) @@ -12,10 +12,10 @@ COMMENT= Fast MP3 encoder kit LICENSE= LGPL20+ PATENTS LICENSE_COMB= multi +LICENSE_NAME_PATENTS= Intellectual Property Precaution LICENSE_FILE_LGPL20+ = ${WRKSRC}/COPYING -LICENSE_NAME_PATENTS= Intellectual Property Precaution +LICENSE_FILE_PATENTS= ${FILESDIR}/lame_patents.txt LICENSE_PERMS_PATENTS= dist-mirror dist-sell no-pkg-mirror no-pkg-sell auto-accept -LICENSE_FILE_PATENTS= $(FILESDIR)/lame_patents.txt USES= gmake iconv libtool USE_LDCONFIG= yes