From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 13 20:40:01 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 179021065673 for ; Sun, 13 Apr 2008 20:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E6AC58FC2E for ; Sun, 13 Apr 2008 20:40:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3DKe0Aw083300 for ; Sun, 13 Apr 2008 20:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3DKe07u083299; Sun, 13 Apr 2008 20:40:00 GMT (envelope-from gnats) Resent-Date: Sun, 13 Apr 2008 20:40:00 GMT Resent-Message-Id: <200804132040.m3DKe07u083299@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Skalozubov Ilia Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E541106566C for ; Sun, 13 Apr 2008 20:31:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 7B6268FC0C for ; Sun, 13 Apr 2008 20:31:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3DKUwhG027663 for ; Sun, 13 Apr 2008 20:30:58 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m3DKUwhd027662; Sun, 13 Apr 2008 20:30:58 GMT (envelope-from nobody) Message-Id: <200804132030.m3DKUwhd027662@www.freebsd.org> Date: Sun, 13 Apr 2008 20:30:58 GMT From: Skalozubov Ilia To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/122735: [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 20:40:01 -0000 >Number: 122735 >Category: ports >Synopsis: [patch] Port mail/postfixadmin - incorrect syntax in mysqli_real_escape_string function >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Apr 13 20:40:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Skalozubov Ilia >Release: >Organization: >Environment: >Description: Incorrect syntax of function mysqli_real_escape_string in functions.inc.php This error occurs when option 'magic_quotes_gpc' disabled in php config and postfixadmin used own functions to quoting strings. >How-To-Repeat: Install postfixadmin with mysqli support. Disable 'magic_quotes_gpc' in php config. Open http://URL_TO_POSTFIXADMIN/admin/create-domain.php When press button to create new domain, you'll get error messages. >Fix: Patch attached with submission follows: --- functions.inc.php 2008-04-13 22:09:18.000000000 +0300 +++ functions.inc.php 2008-04-13 22:09:32.000000000 +0300 @@ -129,7 +129,12 @@ if (get_magic_quotes_gpc () == 0) { if ($CONF['database_type'] == "mysql") $escaped_string = mysql_real_escape_string ($string); - if ($CONF['database_type'] == "mysqli") $escaped_string = mysqli_real_escape_string ($string); + if ($CONF['database_type'] == "mysqli") + { + $link = db_connect (); + $escaped_string = mysqli_real_escape_string ($link, $string); + mysqli_close ($link); + } if ($CONF['database_type'] == "pgsql") $escaped_string = pg_escape_string ($string); } else >Release-Note: >Audit-Trail: >Unformatted: