Date: Sat, 21 Mar 2015 20:32:11 -0700 From: Jason Helfman <bsd-src@helfman.org> To: Adam Weinberger <adamw@adamw.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Baptiste Daroussin <bapt@FreeBSD.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files Message-ID: <EFD03D9F-BD0E-430A-8231-0226689EA043@helfman.org> In-Reply-To: <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
FETCH_ARGS ?
- jgh
> On Mar 20, 2015, at 11:43 AM, Adam Weinberger <adamw@adamw.org> wrote:
>=20
>=20
>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>>=20
>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote:
>>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote:
>>>> +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,}
>>>=20
>>> I think we should put this globally in this 1 line:
>>>=20
>>> bsd.port.mk
>>> 1561 . if defined(GH_TAGNAME)
>>> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME}
>>>=20
>>>=20
>>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.
>>=20
>> Almost in this case upstream decided to put a / in the TAGNAME which is .=
.. well
>> ... :)
>=20
> It would be so unbelievably nice if we had a way to just specify the desti=
nation filename, using fetch -o. All the bizarre names that files are publis=
hed as, the unversioned tarballs, the documentation files labelled Documenta=
tion.pdf, and the fallout from changes like this.... we could make our lives=
so much easier with a DISTFILE_DEST variable.
>=20
> # Adam
>=20
>=20
> --=20
> Adam Weinberger
> adamw@adamw.org
> http://www.adamw.org
>=20
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EFD03D9F-BD0E-430A-8231-0226689EA043>