Date: Sat, 06 May 2023 01:09:29 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 271272] graphics/libcaca: Hidden dependency on Xlib.h Message-ID: <bug-271272-12827-daj1iNBRC3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-271272-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-271272-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-multimedia (Nobody) <multimedia@FreeBSD.org> for maintainer-feedback: Bug 271272: graphics/libcaca: Hidden dependency on Xlib.h https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271272 --- Description --- Note: This bug seems to be a repeat of bug #153846, but I cannot find what about "the process" fixed or stopped this behavior with 0.99beta17, and it's still present with 0.99beta19. Problem: When building libcaca with IMLIB2 port option set, if imlib2 was b= uilt without X11 support, then this error occurs: In file included from ../src/common-image.c:21: /usr/local/include/Imlib2.h:26:10: fatal error: 'X11/Xlib.h' file not found #include <X11/Xlib.h> ^~~~~~~~~~~~ 1 error generated. *** Error code 1 Stop. make[3]: stopped in /wrkdirs/usr/ports/graphics/libcaca/work/libcaca-0.99.beta19/examples *** Error code 1 This is because imlib2 uses the AC_PATH_XTRA macro, and relies on X_DISPLAY_MISSING getting defined when --without-x is passed to imlib2's configure. Within Imlib2.h, There are several #includes and function protot= ypes that are guarded by an #ifndef X_DISPLAY_MISSING. By contrast, libcaca defi= nes its own --enable-x configure flag to permit X11 detection, and only uses the AC_PATH_X macro. Solution: Have a conditional CFLAGS definition for libcaca based on the OPTIONS combination of IMLIB2 set and X11 unset. I will also submit a patch upstrea= m, but libcaca's last commit was 18 months ago, so I am not optimistic it will= be merged.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271272-12827-daj1iNBRC3>