From owner-freebsd-current@FreeBSD.ORG Tue Aug 24 02:54:47 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E95C106567A; Tue, 24 Aug 2010 02:54:47 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from sarah.protected-networks.net (sarah.protected-networks.net [IPv6:2001:470:1f07:4e1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 353368FC12; Tue, 24 Aug 2010 02:54:47 +0000 (UTC) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [202.12.127.84]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "Iain Butler", Issuer "RSA Class 2 Personal CA" (verified OK)) (Authenticated sender: imb) by sarah.protected-networks.net (Postfix) with ESMTPSA id C22636143; Mon, 23 Aug 2010 22:54:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1282618486; bh=teFNRlfSQqlboReRVIpR8eymQ8HivXCdnIqfEYspzRY=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=nkLqSPR5YJwSmGoE5pZNDAATMCX169DyblGNbmnht0317SGMqLp0fu0dUmhYxUnpM olH+Y084PO+Vcrfa4CM1XRBabNIeahHsMq8H9y7daVv0ug76XZ/jV0bDfGAjOI3 DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=bHsu0RRf/Wv3FEriC3pEDqWYg+iHdipUDefyikKEaPOmKJiEphTvQHdXVGgkogvGZ X9EPDjACBAp5Mlia3AkfCMJRF1xenaIj+YvNeZoH1Ydq7GJZhJFILChsatrIY+K Message-ID: <4C733471.3000202@protected-networks.net> Date: Mon, 23 Aug 2010 22:54:41 -0400 From: Michael Butler User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100807 Thunderbird/3.1.2 MIME-Version: 1.0 To: Kostik Belousov References: <4C7011B9.4020902@protected-networks.net> <20100822132104.GA7300@x2.osted.lan> <20100823211257.GI2396@deviant.kiev.zoral.com.ua> In-Reply-To: <20100823211257.GI2396@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 1.1.2 OpenPGP: id=0442D492 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Peter Holm , Jeff Roberson , current@freebsd.org Subject: Re: softupdate with journal panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2010 02:54:47 -0000 On 08/23/10 17:12, Kostik Belousov wrote: > On Sun, Aug 22, 2010 at 03:21:04PM +0200, Peter Holm wrote: >> On Sat, Aug 21, 2010 at 01:49:45PM -0400, Michael Butler wrote: >>> While updating sysutils/coreutils port on -current as of this morning >>> (SVN r211550), I noted a panic during the directory rename config test. >>> >> >> Your problem seems identical to this report: >> >> http://docs.freebsd.org/cgi/mid.cgi?AANLkTinPjiOV21kDLZYV5WScrhLMN7DY8E8jVHWPU5mC >> > I believe that dotdotremref in this case is legitimately NULL. With this > assumption, the following patch would help. Confirmed - with the patch below, it works as expected; thanks! imb > > diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c > index b666c0f..65e5255 100644 > --- a/sys/ufs/ffs/ffs_softdep.c > +++ b/sys/ufs/ffs/ffs_softdep.c > @@ -6770,7 +6794,8 @@ cancel_diradd(dap, dirrem, jremref, dotremref, dotdotremref) > mkdir->md_jaddref = NULL; > if (mkdir->md_state & MKDIR_PARENT) { > if (cancel_jaddref(jaddref, NULL, > - &dirrem->dm_jwork) == 0) { > + &dirrem->dm_jwork) == 0 && > + dotdotremref != NULL) { > free_jremref(dotdotremref); > dotdotremref = NULL; > }