From nobody Fri Jul 31 14:19:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBSrQ0d4Hz6mtMF; Fri, 31 Jul 2026 14:19:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBSrP74Bbz3cVm; Fri, 31 Jul 2026 14:19:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785507590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2JXJA3DNAjwsL+C5DtLCzsHxCVXwtm1CR1jcfcIqDb4=; b=P70Fj4MkvoD9hfz3S+qeL+MDT7cFifzgpjoNzqWOtZW7fw/2sJU03eMTZTVh72wYYrejpl Q2+vlXr5IT1MN4N+RRdrcA01vh8/nmTJKPMYoAy38IzXq6h7CaG+2udN4zQ3PO8cS22+vZ Qc6cdOAmDf1rWsAqfKkAsRob4bNaEonWHxrQKIgqYicdKm7jJn1molUdLAIKzdEM+HgANM xTxaT+fZOwOjXvUsPLC6yfUHl97nvCkKgQw4ozbxaMuRo3dsJ+x6D6F6P9mrFT/nboja+P omtzg065P8VPpVjZjwcvxdreEBFcgzIH2VBATHznwmcALru1ay/C4r5csaPAWw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785507590; a=rsa-sha256; cv=none; b=YO9Dr0nHUKWq0avrb60j8vNeykhJIj5J3ExPmpP/E40QN2JOeYRp1CckAA6/pfmCIQ0MBf IquawGbu2urH7G6Z/w3Au0tAzwHfRpeBlCVAuWwYgra4Om6G1DLuUajCDG9V2oKQAfU4Ca xah0/jp1xyJc54+ShWtyky5FrjfvIat/+Qn8TOjhd6uekPgjxM5tJmacDciU4r88Jgvzhy NRo/sFKK5kc2thUq+LO4MCZvFmEXfv+B4bhivjQU/jKi/NOFQX04jQbX7G68OwIR1UBAIi AmzFgpL41xXcnvOhvFJ6Hr+d4ALYi0b1nh4AWarigMHNuFUMF4OC2Eqt35xm7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785507590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2JXJA3DNAjwsL+C5DtLCzsHxCVXwtm1CR1jcfcIqDb4=; b=j9Ej/BvN9Wz3NeYdSggJJmZdHapxDGwfgntoadzhcAjsj1Z/stfatyN7vg0dNI1ip/I+DK jpQU2Tt7UkuFe35MWDkDa0vPyxunjHgGb/9+UOXq09WybKHS3cAjEShSNgUYnLYmY5EZzR PJCK967kCIdTnQrf4k5XUQBvbFze8fgL4bD/zhPmolSXtSYFdvjloeyn34P8yLuguf6u48 I+Qw4KUq8jwTqOq55g308iBqOadBX2cDEgjqKDKL/4Ek88Ud22W3B7q/xkHNfS6peWHi9B OiX1VgehfHrGvxQO7UOiomvMhpoiqyZE3pswy2EdVBk8klUq3AcbCncO+3PjQA== Received: from [IPV6:2601:5c0:4202:5670:88cd:cc01:662a:da1b] (unknown [IPv6:2601:5c0:4202:5670:88cd:cc01:662a:da1b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hBSrP4lPDznQM; Fri, 31 Jul 2026 14:19:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9c395341-2b97-4a38-b387-dd0b919d0a8b@FreeBSD.org> Date: Fri, 31 Jul 2026 10:19:48 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: ea44c37d0bd1 - main - OFED: Add generic function to extract IB speed from netdev Content-Language: en-US To: "Bjoern A. Zeeb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a6a4a27.40471.422e3907@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/26 19:22, Bjoern A. Zeeb wrote: > On Wed, 29 Jul 2026, John Baldwin wrote: > >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=ea44c37d0bd15e796c85f84b57c211ac220c550c >> >> commit ea44c37d0bd15e796c85f84b57c211ac220c550c >> Author: John Baldwin >> AuthorDate: 2026-07-29 18:42:19 +0000 >> Commit: John Baldwin >> CommitDate: 2026-07-29 18:42:19 +0000 >> >> OFED: Add generic function to extract IB speed from netdev > > This is really confusing to me and I point this out given one of the many > "this is not wireles" LinuxKPI parts I had to do in the past was to > "divorce" netdev being an ifnet as one was aliased to the other in the > past not allowing us to have the Linux native fields we nowhere used and > had edited away (all before my time). > > And I was like "we have no support for any of this in LinuxKPI -- how > can this work" until I saw the if_t. > > We should really start calling ifnet ifnet and no longer netdev unless > we make netdev work on top of ifnet and it is a net_device again. The title was borrowed from the upstream Linux commit. It's true that s/struct netdev/if_t/ is one of the changes I have to make every time I backport an RDMA/OFED commit which is pretty annoying, but this commit continues that trend. OTOH, renaming the local 'netdev_speed' variable in the function would just be a gratuitous diff relative to upstream that would make future merges harder. -- John Baldwin