From owner-svn-src-projects@FreeBSD.ORG Tue Mar 2 13:35:43 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27804106564A; Tue, 2 Mar 2010 13:35:43 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id D9BE78FC08; Tue, 2 Mar 2010 13:35:42 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id C3EED1FFC22; Tue, 2 Mar 2010 13:35:41 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 9C13784549; Tue, 2 Mar 2010 14:35:41 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Bruce Simpson References: <201003012130.o21LUB0I022574@svn.freebsd.org> <201003011744.45410.jhb@freebsd.org> <20100302082214.GA24947@freebsd.org> <4B8D07D3.6000303@incunabulum.net> Date: Tue, 02 Mar 2010 14:35:41 +0100 In-Reply-To: <4B8D07D3.6000303@incunabulum.net> (Bruce Simpson's message of "Tue, 02 Mar 2010 12:42:59 +0000") Message-ID: <86k4tun8wi.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, Roman Divacky , src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r204537 - in projects/clangbsd/contrib/libstdc++: include/ext src X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2010 13:35:43 -0000 Bruce Simpson writes: > Roman Divacky writes: > > John Baldwin > > > Roman Divacky writes: > > > > _Rope_RopeLeaf<_CharT, _Alloc>* __l > > > > =3D (_Rope_RopeLeaf<_CharT, _Alloc>*)this; > > > > - __l->_Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf(); > > > > + __l->template _Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf= (); > > > Hmm, this hurts my brain to have 'template ' in the middle of a deref= erence. > > > I also don't see why it should be needed. > > C++ seems to work this way... it's ugly yes, but correct > +1. You do need to qualify the use of templates in situations like this. It is customary to use typedefs to avoid having to type the full name every time... but IIUC, this is vendor code, so it should be fixed upstream, if at all. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no