From owner-cvs-src@FreeBSD.ORG Wed Apr 28 00:37:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18CA916A4CE; Wed, 28 Apr 2004 00:37:22 -0700 (PDT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6105143D67; Wed, 28 Apr 2004 00:37:21 -0700 (PDT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i3S7gbHW010765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Apr 2004 10:42:39 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i3S7bBp6025526; Wed, 28 Apr 2004 10:37:11 +0300 (EEST) (envelope-from ru) Date: Wed, 28 Apr 2004 10:37:10 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20040428073710.GD25064@ip.net.ua> References: <200404271907.i3RJ7ZkI028848@repoman.freebsd.org> <20040427192403.GC75827@ip.net.ua> <20040428144757.T4950@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mSxgbZZZvrAyzONB" Content-Disposition: inline In-Reply-To: <20040428144757.T4950@gamplex.bde.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/i386/boot0 Makefile boot0.s boot0_512.s boot0sio.s X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2004 07:37:22 -0000 --mSxgbZZZvrAyzONB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 28, 2004 at 02:52:39PM +1000, Bruce Evans wrote: > On Tue, 27 Apr 2004, Ruslan Ermilov wrote: >=20 > > On Tue, Apr 27, 2004 at 12:07:35PM -0700, Poul-Henning Kamp wrote: > > > phk 2004/04/27 12:07:35 PDT > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/boot/i386/boot0 Makefile > > > Added files: > > > sys/boot/i386/boot0 boot0_512.s > > > Removed files: > > > sys/boot/i386/boot0 boot0.s boot0sio.s > > > Log: > > > Change from '#' to "//" comment character to allow CPP preprocessin= g. > > > > > This is backwards, please fix. Also, the preprocessed files >=20 > So "# foo" is a valid comment and not a preprocessor directive in *.S > provided "foo" is not a standard preprocessor directive? >=20 Hmm, no it's not. I will fix all .S files under sys/boot/ to use a proper syntax for single-line comments (`//'). Only lines that _start_ with `#' need to be fixed. My main point still applies: adding a special CPP preprocessing to this makefile was backwards, having the .S file is enough, though I confirm that I was confused about single-line comments in the mixed (assmebler + CPP) input. Reading the cpp.info now revealed the truth. Nevertheless, I've ordered a repo-copy of boot0sio.s to boot0.S. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --mSxgbZZZvrAyzONB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAj18mUkv4P6juNwoRAg6LAKCLYvVTD7+V2pHPQYp5SkQc0kDkHgCfeBjN D8uaNSnu3Ar3qGCYj2IyDu0= =OEac -----END PGP SIGNATURE----- --mSxgbZZZvrAyzONB--