From nobody Wed Apr 5 17:01:01 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ps9rF61tPz43lmd; Wed, 5 Apr 2023 17:01:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ps9rF5X7Wz44s8; Wed, 5 Apr 2023 17:01:01 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680714061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7XYxhovUf9UayNBh3tZx73Qpg+QM9KYfP9KSxz2Rng4=; b=PXNXwQkwCZtr9lh1b9DsiGhQSwv9+3km07FHEMzsSB00q74mpMIhJjEqtLphjN0QA/857n KQ4Tr5yGphMH7wV+44XG2Fj8kdw+i97c11Fept6clVkoptDQQHcpGZQKAb8EOy/6VDyqFN Q2PedcXLq5u/gy+kSXTEQ8xIhOzHHwU2BOHdupqlA5nmuk44OR5Zeu5xCZa+4eDNCcKJQw 9PHwhWHn+kNLZKUsApjxrwrumR91q6Pcwq1k2/TEHrpE4dfx00ZhsUv5280TdOcfXwZhNn BTA4vedYKnkdfgZYNWaZ02I/yaYPtrsR/I/QWLYvEnWYTtbaRPRuQW3VuuuR+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680714061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7XYxhovUf9UayNBh3tZx73Qpg+QM9KYfP9KSxz2Rng4=; b=PXm3ktCOFGFqo71yiZGK9E/xVT3Vgz38unsrLpgLTstI3vjMO4Xy0/YfQlQbPB+WF8fB+1 MaFNK1X9g5Dp/tgarBdeM0x5NxovGZSBffIVwuoGhFsIr3BdJXXGbBWf8hOnEiQ0M5uHef Bnd7rG0b4h3nxozGsb0H5pAXDK+SjUdCTM9WD8+KZ6lvrqN5X3426405apF0j7CvUbzpaR MNABx5+Tjp3M+sPXTosOL9dHGTR0P+CAL7OlWy5mTF2PUWlrfOYPFx6aG/Oy/KJUx7dpDg xc4E60uo9nF2M/uTp0b3QAzlliRVVGlh84Z6MGhrq6IDWtYzFQHBJRgBpbHv1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680714061; a=rsa-sha256; cv=none; b=wP/gXuh99qbvbhITW9O/3a4Ll736MSQ5a0Tw84AN82a6JhlMdDWaZUZ1xx/mVRZub9lVDi G5xT2TAWYbCcqIWfOEPgAhwCcKmSEotWt6Vh7TVedTPYoOmSjUUUXMDbLCbTjsMtHO46vl uum6Ann8IhAWqAKpd+Sf0kE9IAJUP8qsmeYZTVkUOddClYItW1U5AGtBaOoz08gVcyohoe +QERgfMLZTGDJgCN27QAkZ2qJ7XCq1B+RPhSo7xbiYyVOOo2X/Uzih4P7prsBsBOVdQhGk w3cMj0YxqbMDlIrIB8VFk5F92JMq0x+j7hC/xloqI8GLjFDVkaGdTtQc1WZb3A== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 962081A495; Wed, 5 Apr 2023 17:01:01 +0000 (UTC) Date: Wed, 5 Apr 2023 17:01:01 +0000 From: Alexey Dokuchaev To: Moin Rahman Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4cda17ab1458 - main - */*: Refactor java/openjdk7 removal Message-ID: References: <202304041811.334IB93k074119@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 05, 2023 at 06:59:15PM +0200, Moin Rahman wrote: > > On Apr 5, 2023, at 5:48 PM, Alexey Dokuchaev wrote: > > On Tue, Apr 04, 2023 at 06:11:09PM +0000, Muhammad Moinur Rahman wrote: > >> commit 4cda17ab14588e6e4fdac7f697e246554ce82af3 > >> > >> Refactor java/openjdk7 removal > >> > >> - Since the introduction of jdk version 18 it looks like similar with > >> jdk version 8(java version string 1.8). This is prone to error as it > >> looks similar and is only seperated by a '.'. Remove using > >> JAVA_VERSION with dotted fomat of java version string and update all > >> consumers to utilize version 8 instead of 1.8. > >> > >> @@ -17,7 +17,7 @@ NO_WRKSUBDIR= yes > >> > >> USES= zip:infozip > >> USE_JAVA= yes > >> -JAVA_VERSION= 1.8+ > >> +JAVA_VERSION= 8+ > > > > Perhaps we should drop JAVA_VERSION as USE_JAVA accepts versions similar > > to USE_GCC; separate JAVA_VERSION is just a needless cognitive burden. > > You speak my mind; but one step at a time. That is planned in step 2 and in > step 3 I am going to convert this into USES=java. Awesome, thank you! ./danfe