From owner-freebsd-toolchain@freebsd.org Sun Nov 22 04:43:27 2020 Return-Path: Delivered-To: freebsd-toolchain@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7A91247C9D4 for ; Sun, 22 Nov 2020 04:43:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CdyMz2wj8z4Y0G for ; Sun, 22 Nov 2020 04:43:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id h11so1621913qkl.4 for ; Sat, 21 Nov 2020 20:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=70jn3KP5ftCdeVO0WDb7030bqJt+/DSCeNr+TZIRX/w=; b=uoHNtq0O3tPP8wQmeWIAQx8j8PXqKboUEw94dScBWrVEr0ph47jryNHl7jM5bASXsL lENlkTngJNXB2NJNOMAgkC771d6XtPcDc5ayKoFaadIBW3Yez1KtwU+rkk+9sIeQWl4z 4o53Z8WcHocYI2Czs1umMzYCcqjyvXGvb1CU35duZ8ue8z+lY+ZUDs9qsujMk+yjjM+P xJINpc6CslIosBOQNg/OArGgDwhabOFXOk7tXxdlk72pWU4u7nv+i2hzqoi/HESLq3S4 JMfU4dCRRMiMnMT3Xp012Umacy0WbUFud1rXvGmEIzYZUOR8ojt5CKSFygQAPZoNX3xG iqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=70jn3KP5ftCdeVO0WDb7030bqJt+/DSCeNr+TZIRX/w=; b=XByTKjDbo8kzh0RiiTt9wrWzFCIv4k24CpFBzk0iAep2+S+SE9vw8fm+qPPZ7T/JH0 vlb4z44NvW23yi8JqrEzdIZOqSKryj8CiFLJmvXVeEZZpAHNWnGACwElQXlyNyMyLFx6 DApG56IjoR+VTD3InlN4gRi8x0hRjwAL/fBipaXcEDwp2cuSNqOWQ5simTEMSztxJDuG o9O7Jooq40ohf9WJ15a86AFW5HxHe1B7JV+/QLeEoZ08iHSEpEBf1jC/52jpUxEnpUDJ 5WNnrlOGAVRlPzsX2TxHkcLLV8h9zVjNGSHw6gI/r1vO8vIl990kh9lpyV+KGXFSvZSq +a2w== X-Gm-Message-State: AOAM531GJ9Ff/p4bqb4vsodjmxMrqUPpesSTIn/4pCpkuXQbM/lBLJ8r jUcmi1btJnPs7Zcez+fuHGI32rWW/AlGcDkXcmkPew== X-Google-Smtp-Source: ABdhPJxwWHZkuatAZcaXXqTXHS1JZeXegB+mMyvfB+xNh2S1BUf9+iI35gE3qvVXjOplTuKSq+jm5X/LIPzGcrrS2xA= X-Received: by 2002:a37:e207:: with SMTP id g7mr24027026qki.44.1606020206354; Sat, 21 Nov 2020 20:43:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 21 Nov 2020 21:43:15 -0700 Message-ID: Subject: Re: Remove ftime() interceptor defs from compiler-rt/FreeBSD To: Kyle Evans Cc: FreeBSD Toolchain X-Rspamd-Queue-Id: 4CdyMz2wj8z4Y0G X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2020 04:43:27 -0000 On Sat, Nov 21, 2020, 9:26 PM Kyle Evans wrote: > Hi, > > Can we remove the ftime() interceptor definitions that are FreeBSD > specific in compiler-rt? See: > https://people.freebsd.org/~kevans/intercept.diff -- the very act of > including sys/timeb.h adds build noise from the warning about it being > deprecated, when ftime() is apparently not even intercepted on > FreeBSD: > > #define SANITIZER_INTERCEPT_FTIME \ > (!SI_FREEBSD && !SI_NETBSD && !SI_OPENBSD && SI_POSIX) > Seems legit. Time is marked legacy in xopen. It was only a thing on V7. BSD4 added the replacement gettimeofday(). I'm not seeing any reason to not do this, but I've not looked into this in depth... This hasn't been an important function in a long time. Warner Thanks, > > Kyle Evans > _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to " > freebsd-toolchain-unsubscribe@freebsd.org" >