From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:36:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02B3316A4CE; Wed, 3 Nov 2004 16:36:35 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9126D43D66; Wed, 3 Nov 2004 16:36:34 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA3GcOu3020383; Wed, 3 Nov 2004 09:38:24 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <41890956.2030705@freebsd.org> Date: Wed, 03 Nov 2004 09:37:42 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Luigi Rizzo References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> In-Reply-To: <20041103082806.C49241@xorpc.icir.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:36:35 -0000 Luigi Rizzo wrote: > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: > ... > >>I think that in general we can start eyeing a lot of similar verbosity >>in all of our drivers, both at boot and at runtime. For example most >>nic drivers print out their MAC and all of their possible negotiation >>rates on attach. This same info can be obtained from ifconfig. Why >>clutter the boot with it? > > > because sometimes you might need to enable some MAC-based filter > before you have a chance to access the box. e.g. to set dhcp/bootp > anbd the like. > > A bit of verbosity is useful, you can always switch to splash screens > if you don't like them. > > I think the link-up/link-down thing is different because it > happens not just at boot but also whenever the link status > changes (e.g. when a spanning tree on a switch detects a > reconfiguration), and this is annoying on the console. > > cheers > luigi > I'm not saying that these things should be removed, just places under bootverbose. Situations like what you are saying are rare and/or one-time occurances. And if you look at drivers like if_ath(no offense meant towards Sam): ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on cardbus1 ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 ath0: Ethernet address: 00:0c:41:15:5f:94 ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps The last 4 lines could easily go under bootverbose. I'd even wager that the second line can be hidden also; it provides little useful information for a normal boot. Scott