From owner-freebsd-hackers@FreeBSD.ORG  Fri Dec 14 19:10:52 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (unknown [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 791966A8
 for <freebsd-hackers@freebsd.org>; Fri, 14 Dec 2012 19:10:52 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com
 [209.85.223.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 1E3528FC0C
 for <freebsd-hackers@freebsd.org>; Fri, 14 Dec 2012 19:10:51 +0000 (UTC)
Received: by mail-ie0-f182.google.com with SMTP id s9so6501561iec.13
 for <freebsd-hackers@freebsd.org>; Fri, 14 Dec 2012 11:10:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=RDQ4ARBjk1bN/8Ud8liijidKc0w4oQ5QK4ZzxGnJFSE=;
 b=XkF44UfUVo7wcFOAWLhBEKFpWzIFTCYd8NNrxjbsiBo3raufysoaHx/PX4LRrghpMd
 qMotyJ3tKDuTPU1L1KBrj5jtTkLA43iYrlQ78Z0g+WdmWngs77knIVoZcjIai+An1+BX
 A4z7cD05btwb400NS51IB4ivszhVGBDqyngVzW2P/mFDzQ5EutflxTh+mqTiELAqijfM
 xI3CDJZ6+RhMAbvCQN5KZ/bEZMPzeDbGBMZUgR8WOMF8EPYDE6fYIzAlTK9BCQV3nMMV
 kDgazvTgDMBaGd8Fu2NqZRx3qecpXpOW0omlghmsy/yufBzD0Ue5AxwgRAF+Ogw3vxD5
 1Y8g==
MIME-Version: 1.0
Received: by 10.50.37.168 with SMTP id z8mr2734139igj.1.1355512251580; Fri, 14
 Dec 2012 11:10:51 -0800 (PST)
Sender: carpeddiem@gmail.com
Received: by 10.50.112.134 with HTTP; Fri, 14 Dec 2012 11:10:51 -0800 (PST)
In-Reply-To: <50CA51AB.6060801@vangyzen.net>
References: <20121213160847.GA78448@sandvine.com>
 <50CA51AB.6060801@vangyzen.net>
Date: Fri, 14 Dec 2012 14:10:51 -0500
X-Google-Sender-Auth: Y6UqfNGZhZrb3wrASXbovB1pies
Message-ID: <CAPyFy2BP-Y835_kLKOQ6XCv6+Nqfe4_nqQZ1ojrXj8ZKpUc6Eg@mail.gmail.com>
Subject: Re: [PATCH] Shared library debug .symbols files
From: Ed Maste <emaste@freebsd.org>
To: Eric van Gyzen <eric@vangyzen.net>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2012 19:10:52 -0000

On 13 December 2012 17:07, Eric van Gyzen <eric@vangyzen.net> wrote:
>>         @${ECHO} building shared library ${SHLIB_NAME}
>> -       @rm -f ${.TARGET} ${SHLIB_LINK}
>> +       @rm -f ${.SHLIB_NAME} ${SHLIB_LINK}
>
>
> dot-SHLIB_NAME?  I'm not aware of this magic.

No magic, just a typo introduced while transcribing from an isolated
tree.  Thanks for spotting.

>> +${SHLIB_NAME}: ${SHLIB_NAME}.debug ${SHLIB_NAME}.symbols
>> +       ${OBJCOPY} --strip-all --add-gnu-debuglink=${SHLIB_NAME}.symbols\
>> +           ${SHLIB_NAME}.debug ${.TARGET}
>> +
>> +${SHLIB_NAME}.symbols:

Mark Johnston also pointed out I'm missing the ${SHLIB_NAME}.debug
dependency here.