From owner-freebsd-fs@FreeBSD.ORG Sun Jan 23 04:51:51 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1869106566C; Sun, 23 Jan 2011 04:51:51 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 606D78FC0C; Sun, 23 Jan 2011 04:51:51 +0000 (UTC) Received: by wyf19 with SMTP id 19so3116186wyf.13 for ; Sat, 22 Jan 2011 20:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JmBgd/w5Q03mYSmQDjj6aaCFQxwcOZID3woiR2a/MT0=; b=hxXT+68T3BPKj2NMAl33yL3lrBF7Sv87d1gJKetIgaHjV8NT30iSEcfTABvx84wIPW NfkDGXFNKoLDaln0FLo/niO2fuooZZdvtEd4EWoZfYqbEQUUtGx5ysoKC7TV9db9SVwk NiRJu07PsSIbo2i1VOhWlhFKJDqTTOOQo11BE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Ref9oedfE5Z8Hg5nYOHNYAi/CjGmmL9mbVM4hzB88R9s8ZKkCzCjC12r22Rq+5hTeV 3J0hWZqKpYPvfqH0yOj/4H0S32tGr+oSWRwNrROsjqobv2TbtqwQts2IPiwSjSzHfxg5 Fmv1myQqRn7pxroNGKIdV67J7b5VbrimedofI= MIME-Version: 1.0 Received: by 10.216.141.75 with SMTP id f53mr2332358wej.16.1295758310340; Sat, 22 Jan 2011 20:51:50 -0800 (PST) Received: by 10.216.254.226 with HTTP; Sat, 22 Jan 2011 20:51:50 -0800 (PST) In-Reply-To: References: Date: Sat, 22 Jan 2011 20:51:50 -0800 Message-ID: From: Garrett Cooper To: Pawel Jakub Dawidek Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org Subject: Re: Concerns over shim-layers for ZFS and kernel/userland namespace pollution X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 04:51:52 -0000 On Sat, Jan 22, 2011 at 5:06 PM, Garrett Cooper wrote: > Hi Pawel, > =A0 =A0I've been trying to get rid of the time.h pollution in sys/time.h > for POSIX conformance and I've run into a bit of a roadblock > (referring to sys/cddl/compat/opensolaris/sys/time.h): > =A0 =A01. The clock_gettime call in gethrtime() can fail and the failure > itself isn't captured. > =A0 =A02. The calls in many case assume userland behavior, being "return > value", not "return errno, assign value to address passed in" > =A0 =A03. AFAICT the calls shouldn't be calling the clock_gettime syscall > interface from userland; they should be calling the clock_gettime > interface. I could be partly wrong here, but if so then some > additional hacking will need to be made to pull in time.h as that's > where clock_gettime must be defined according to our manpages and > POSIX. There might be another preexisting KPI that can be used in its > place. > =A0 =A0I haven't looked outside of that header for now. > =A0 =A0Comments on my above statements are more than welcome. Nevermind. It looks like I missed the #ifdef _KERNEL ... #else ... #endif lines. It would be nice if the KPIs were consistent with FreeBSD KPIs, but that's less of an issue I suppose. Thanks, -Garrett