From owner-svn-ports-all@freebsd.org  Sat Jun 10 23:16:48 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CCB1BF81DA;
 Sat, 10 Jun 2017 23:16:48 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E1775662D1;
 Sat, 10 Jun 2017 23:16:47 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 191775EC3; Sat, 10 Jun 2017 23:16:47 +0000 (UTC)
Date: Sat, 10 Jun 2017 23:16:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org,
 portmgr@FreeBSD.org
Subject: Re: svn commit: r443039 - branches/2017Q2
Message-ID: <20170610231647.GA99407@FreeBSD.org>
References: <201706091946.v59JkB4D050200@repo.freebsd.org>
 <1497037780.167039.1004506896.6EE77BCC@webmail.messagingengine.com>
 <26f1138a-5b9d-1817-2ddc-a5f876df75df@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26f1138a-5b9d-1817-2ddc-a5f876df75df@FreeBSD.org>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jun 2017 23:16:48 -0000

On Sat, Jun 10, 2017 at 11:51:15PM +0200, Mathieu Arnold wrote:
> Le 09/06/2017 ?? 21:49, Mark Felder a ??crit :
> > This was a no-op and was not supposed to be committed. I accidentally
> > hit "yes" but did not fill in an "Approved by:" line and it allowed the
> > commit anyway, so I believe the pre-commit hook is broken at the moment.
> 
> The pre-commit hook is working just fine, the thing is, you *are* a
> member of portmgr, so you get the "I'm god" treatment, and subversion
> goes along with it :-)

Shouldn't it still require an explicit "(implicit)" line in this case?

./danfe