Date: Wed, 6 Nov 2013 08:18:15 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ganael LAPLANCHE <martymac@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332953 - head/benchmarks/nttcp Message-ID: <20131106081815.GB90001@FreeBSD.org> In-Reply-To: <201311060811.rA68BbBe077262@svn.freebsd.org> References: <201311060811.rA68BbBe077262@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 06, 2013 at 08:11:37AM +0000, Ganael LAPLANCHE wrote: > New Revision: 332953 > URL: http://svnweb.freebsd.org/changeset/ports/332953 > > @@ -14,15 +14,13 @@ COMMENT= A client/server program for tes > RESTRICTED= No commercial use > > ALL_TARGET= nttcp > -MAN1= nttcp.1 > -PLIST_FILES= bin/nttcp > +PLIST_FILES= bin/nttcp man/man1/nttcp.1.gz We usually try to move out PLIST_* knobs in separate block. It makes even more sense since ALL_TARGET, USES, MAKE_ENV, etc. are build-related stuff, while PLIST_* are install/package-related ones. > USES= gmake > MAKE_ENV+= OPT="${CFLAGS}" > NOPRECIOUSMAKEVARS=yes > > -NO_STAGE= yes > do-install: > - ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/ > - ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/ > + ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/ > + ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/ Manual pages should be installed relative to MAN[n]PREFIX, not PREFIX. I also do not see the need for trailing slash, as these directories are guaranteed to exist (they are part of the mtree). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106081815.GB90001>