From owner-freebsd-bugs@freebsd.org Wed Mar 31 11:17:06 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B62F55C3FF9 for ; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4F9P0f4d8wz4vwQ for ; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9CEA05C3FF8; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9CB355C3ED1 for ; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F9P0f3wPsz3BqN for ; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7585118A8E for ; Wed, 31 Mar 2021 11:17:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 12VBH6g8083500 for ; Wed, 31 Mar 2021 11:17:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 12VBH6ep083499 for bugs@FreeBSD.org; Wed, 31 Mar 2021 11:17:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 254675] ICMP Unreach needfrag is broken in 13.0-RC4 Date: Wed, 31 Mar 2021 11:17:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: afedorov@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2021 11:17:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254675 Bug ID: 254675 Summary: ICMP Unreach needfrag is broken in 13.0-RC4 Product: Base System Version: 13.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: afedorov@FreeBSD.org Hello. I have the following setup with two VM's: --- [ FreeBSD 13.0 RC4 GW_VM + NAT ] --- --- [Li= nux VM] GW_VM: Interfaces: vtnet1 vtnet2 192.168.1.1/24 net.inet.ip.forwarding=3D1 NAT pf.conf: nat on vtnet1 from 192.168.1.0/24 to any -> vtnet1 Linux VM: enp0s2 192.168.1 When I'm trying iperf3 from Linux VM to public host: [ 4] local 192.168.1.4 port 49412 connected to port 5201 [ ID] Interval Transfer Bandwidth Retr Cwnd [ 4] 0.00-1.01 sec 263 KBytes 2.14 Mbits/sec 45 5.66 KBytes=20= =20=20=20=20=20=20 [ 4] 1.01-2.00 sec 156 KBytes 1.28 Mbits/sec 32 5.66 KBytes=20= =20=20=20=20=20=20 [ 4] 2.00-3.00 sec 156 KBytes 1.27 Mbits/sec 26 5.66 KBytes=20= =20=20=20=20=20=20 The low upload speed is predictable due to virtio-net offload are enabled. But what I did not expect was the absence of the needfrag ICMP packet. I setup 12.2 RELEASE with same configuration, and root@edge-12:~ # tcpdump -i vtnet2 proto ICMP tcpdump: verbose output suppressed, use -v or -vv for full protocol decode listening on vtnet2, link-type EN10MB (Ethernet), capture size 262144 bytes 14:07:09.803538 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.803581 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.803605 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.806829 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.806856 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.810143 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 14:07:09.810172 IP 192.168.1.1 > 192.168.1.4: ICMP 10.78.28.17 unreachable - need to frag (mtu 1500), length 176 Using the following DTrace script: dtrace -n 'fbt:kernel:icmp_error:entry { stack(); printf("type: %d code: %d", arg1, arg2);}' 12.2-RELEASE work as expected: ip_forward() call ip_output() which return EMSGSIZE -> generate ICMP unreach needsfrag. 0 53981 icmp_error:entry=20 kernel`ip_forward+0x5c4 kernel`ip_input+0x7a7 kernel`netisr_dispatch_src+0xca kernel`ether_demux+0x138 kernel`ether_nh_input+0x33b kernel`netisr_dispatch_src+0xca kernel`ether_input+0x4b kernel`vtnet_rxq_eof+0x7a5 kernel`vtnet_rx_vq_process+0xb7 kernel`ithread_loop+0x23c kernel`fork_exit+0x7e kernel`0xffffffff81067f6e type: 3 code: 4 0 53981 icmp_error:entry=20 kernel`ip_forward+0x5c4 kernel`ip_input+0x7a7 kernel`netisr_dispatch_src+0xca kernel`ether_demux+0x138 kernel`ether_nh_input+0x33b kernel`netisr_dispatch_src+0xca kernel`ether_input+0x4b kernel`vtnet_rxq_eof+0x7a5 kernel`vtnet_rx_vq_process+0xb7 kernel`ithread_loop+0x23c kernel`fork_exit+0x7e kernel`0xffffffff81067f6e type: 3 code: 4 13-RC4: 0 54326 icmp_error:entry=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 kernel`ip_tryforward+0x730=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 kernel`ip_input+0x356=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 kernel`netisr_dispatch_src+0xca=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 kernel`ether_demux+0x148=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 kernel`ether_nh_input+0x34c=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 kernel`netisr_dispatch_src+0xca=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 kernel`ether_input+0x69=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 kernel`vtnet_rxq_eof+0x7d4=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 kernel`vtnet_rx_vq_process+0xb7=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 kernel`ithread_loop+0x24d=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 kernel`fork_exit+0x7e=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 kernel`0xffffffff810625ae=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 type: 3 code: 4=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 1 54326 icmp_error:entry=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 kernel`ip_forward+0x9c=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 kernel`ip_input+0x6cc=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 kernel`swi_net+0x12b=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 kernel`ithread_loop+0x24d=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 kernel`fork_exit+0x7e=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 kernel`0xffffffff810625ae=20 type: 3 code: 1 So, As I understand ip_tryforward() trying to generate ICMP needsfrag, but after that generated ICMP ICMP_UNREACH_HOST. --=20 You are receiving this mail because: You are the assignee for the bug.=