From owner-freebsd-current@FreeBSD.ORG Wed Oct 5 00:43:51 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DF1A106564A for ; Wed, 5 Oct 2011 00:43:51 +0000 (UTC) (envelope-from bounces+73574-dfb6-freebsd-current=freebsd.org@sendgrid.info) Received: from o3.sendgrid.info (o3.sendgrid.info [67.228.50.51]) by mx1.freebsd.org (Postfix) with SMTP id 2B0598FC0A for ; Wed, 5 Oct 2011 00:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=1Va/SICUiQ360aOJmMP2U+r3N3M=; b=t8SDpHaY6MY1rcoYRzkPvy3WaS9N AvXmX5VtitZQCWAUzXunJg7UsYv+XJCyNh7phkSkw0s6q9O6HvKR8HS4GqUCg+fB SapDovYH4a61hWEoevaM+wyRbYYPzObyF8G4bRTlehvBNwlamm+9osN2OK3pgDcX L6Nt7Be302AvsOw= Received: by 10.12.16.48 with SMTP id mf8.31358.4E8BA3F59 Tue, 04 Oct 2011 19:25:25 -0500 (CDT) Received: from mail.tarsnap.com (unknown [10.9.180.5]) by mi8 (SG) with ESMTP id 4e8b79a7.4036.82e13b7 for ; Tue, 04 Oct 2011 16:24:55 -0500 (CST) Received: (qmail 25992 invoked from network); 4 Oct 2011 21:23:03 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 4 Oct 2011 21:23:03 -0000 Received: (qmail 7825 invoked from network); 4 Oct 2011 21:24:48 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 4 Oct 2011 21:24:48 -0000 Message-ID: <4E8B79A0.7080609@freebsd.org> Date: Tue, 04 Oct 2011 14:24:48 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:6.0.2) Gecko/20110914 Thunderbird/6.0.2 MIME-Version: 1.0 To: Jilles Tjoelker References: <4E8AE0CD.8010805@FreeBSD.org> <20111004210845.GA68922@stack.nl> In-Reply-To: <20111004210845.GA68922@stack.nl> X-Enigmail-Version: undefined Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: XhyBwObMhraAR+zdwMupjQ6BIqbhdEfc+6p+uBxS7S/JdXLHUikvG068B5KgeRndVviJ/+F4Jvp3J8jO3KQKsc8yaRfPbAfwnh5FprfetU5eSdTIF0D2nxrmDUtjnzzrm6mB2jdcSkTdv6URQrJVr5LDq4r5XSqfPE1bhwITwrs= Cc: FreeBSD-Current , Andriy Gapon Subject: Re: portsnap5 problem, portsnap error handling X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2011 00:43:51 -0000 On 10/04/11 14:08, Jilles Tjoelker wrote: > The important part is the error from [. Because the check is for > inequality, in case of a [ syntax error the "equal" path is taken and > the script continues as if everything is fine. > > The script arrives there because of a missing backslash so that the > fetch(1) command's exit status is not checked. > > The below patch should fix this fairly simply. [...] Aha! I don't know how many times I've looked at that code and thought "I don't understand, why isn't it returning from this function?" Please feel free to commit this fix. For the benefit of the list: It looks like there was a short period this morning when several portsnap mirrors were out of sync due to the mirroring cron jobs running into a network outage somewhere around portsnap-master. Everything should be back to normal now. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid