Date: Tue, 04 Oct 2011 14:24:48 -0700 From: Colin Percival <cperciva@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: FreeBSD-Current <freebsd-current@FreeBSD.org>, Andriy Gapon <avg@FreeBSD.org> Subject: Re: portsnap5 problem, portsnap error handling Message-ID: <4E8B79A0.7080609@freebsd.org> In-Reply-To: <20111004210845.GA68922@stack.nl> References: <4E8AE0CD.8010805@FreeBSD.org> <20111004210845.GA68922@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/04/11 14:08, Jilles Tjoelker wrote: > The important part is the error from [. Because the check is for > inequality, in case of a [ syntax error the "equal" path is taken and > the script continues as if everything is fine. > > The script arrives there because of a missing backslash so that the > fetch(1) command's exit status is not checked. > > The below patch should fix this fairly simply. [...] Aha! I don't know how many times I've looked at that code and thought "I don't understand, why isn't it returning from this function?" Please feel free to commit this fix. For the benefit of the list: It looks like there was a short period this morning when several portsnap mirrors were out of sync due to the mirroring cron jobs running into a network outage somewhere around portsnap-master. Everything should be back to normal now. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E8B79A0.7080609>