From owner-freebsd-current@freebsd.org Thu Aug 20 11:50:47 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A22D9BE433 for ; Thu, 20 Aug 2015 11:50:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 091BD1746; Thu, 20 Aug 2015 11:50:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t7KBofIn088460 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 20 Aug 2015 14:50:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t7KBofIn088460 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t7KBoffm088451; Thu, 20 Aug 2015 14:50:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 20 Aug 2015 14:50:41 +0300 From: Konstantin Belousov To: Mark Felder Cc: freebsd-current@freebsd.org Subject: Re: pkg with an ssh repo crashes CURRENT Message-ID: <20150820115041.GU2072@kib.kiev.ua> References: <1440014993.2793501.360634953.2FF3B076@webmail.messagingengine.com> <1440021176.3252738.360727753.7FEDAB82@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440021176.3252738.360727753.7FEDAB82@webmail.messagingengine.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2015 11:50:47 -0000 On Wed, Aug 19, 2015 at 04:52:56PM -0500, Mark Felder wrote: > panic: children list > cpuid = 0 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe01228ea840 > vpanic() at vpanic+0x189/frame 0xfffffe01228ea8c0 > kassert_panic() at kassert_panic+0x132/frame 0xfffffe01228ea930 > kern_procctl_single() at kern_procctl_single+0x81c/frame > 0xfffffe01228eaa00 > kern_procctl() at kern_procctl+0x223/frame 0xfffffe01228eaa50 > sys_procctl() at sys_procctl+0xa5/frame 0xfffffe01228eaae0 > amd64_syscall() at amd64_syscall+0x282/frame 0xfffffe01228eabf0 > Xfast_syscall() at Xfast_syscall+0xfb/frame 0xfffffe01228eabf0 The fired assert means that there was a reaper process with some children but without descendands to be reaped. Hm, I can imagine this situation to happen if e.g. some not-reaper forks and then acquires reaper status. The patch below removes too aggressive asserts. Still, it would be interesting to look into the process table. Please repeat the procedure to panic, then in ddb do 'ps'. After that do 'dump' and please keep kernel.debug and vmcore around. First I want to look at the ps output. diff --git a/sys/kern/kern_procctl.c b/sys/kern/kern_procctl.c index d65ba5a..8ef72901 100644 --- a/sys/kern/kern_procctl.c +++ b/sys/kern/kern_procctl.c @@ -187,8 +187,6 @@ reap_status(struct thread *td, struct proc *p, } } else { rs->rs_pid = -1; - KASSERT(LIST_EMPTY(&reap->p_reaplist), ("reap children list")); - KASSERT(LIST_EMPTY(&reap->p_children), ("children list")); } return (0); }