From owner-freebsd-bugs Fri Jan 10 22:12:12 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id WAA01477 for bugs-outgoing; Fri, 10 Jan 1997 22:12:12 -0800 (PST) Received: from hydrogen.nike.efn.org (metriclient-3.uoregon.edu [128.223.172.3]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id WAA01472 for ; Fri, 10 Jan 1997 22:12:06 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by hydrogen.nike.efn.org (8.8.4/8.8.4) with SMTP id WAA12535; Fri, 10 Jan 1997 22:11:28 -0800 (PST) Date: Fri, 10 Jan 1997 22:11:28 -0800 (PST) From: John-Mark Gurney Reply-To: John-Mark Gurney To: Frank Durda IV cc: freebsd-bugs@freebsd.org, j@uriah.heep.sax.de Subject: Re: bin/2303 & kern/2423 CDs and BCD numbers - its 99 DECIMAL not HEX In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-bugs@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Fri, 10 Jan 1997, Frank Durda IV wrote: > From: j@uriah.heep.sax.de (J Wunsch) > [...that the track number is in BCD on the disk, yes, we know.] > > [0]Now, there are plenty of makes of CD-ROM drives that return info to > [0]the host in BCD, and this is because most of the fields on the actual disk > [0]are in BCD. > > [1]Yes, but SCSI requires the drive to return it as an integer value. > [1]Any drive returning BCD is violating the specs. > > Agreed. My point all along is that we should not incorporate any > change that allows for more than 99 DECIMAL tracks, even if there is > (A) media cut that way and (B) one drive that can cope with it. > Too many things will fall over. the fix I supplied in kern/2423 doesn't do this... what it does is on certain drives the numbers returned are bcd encoded... what this patch does is you add a flag to the quirks entry that says this drive needs help... like: { T_READONLY, T_READONLY, T_REMOV, "CHINON", "CD-ROM CDS-535","*", "cd", SC_ONE_LU, CD_Q_BCD_TRACKS }, see the CD_Q_BCD_TRACKS flag? this means and drives that match the above entry then special code is enabled in the scsi cd driver that will convert all track ids from bcd to binary... as I followed up.. as soon as kern/2423 gets commited then bin/2303 can be closed without the patch being commited... the patch in bin/2303 was because I didn't recognize that every ten tracks 5 tracks were skipped... it just looks like they decided to skip tracks... I didn't know that tracks on cds were required to NOT skip tracks... I just thought that the NIN cd was doing some special stuff... hope this helps clarify the problem... ttyl... John-Mark gurney_j@efn.org http://resnet.uoregon.edu/~gurney_j/ Modem/FAX: (541) 683-6954 (FreeBSD Box) Live in Peace, destroy Micro$oft, support free software, run FreeBSD (unix)