Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Dec 2017 08:13:39 +0000 (UTC)
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r457025 - head/textproc/senna
Message-ID:  <201712230813.vBN8DdgF030164@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: danfe
Date: Sat Dec 23 08:13:39 2017
New Revision: 457025
URL: https://svnweb.freebsd.org/changeset/ports/457025

Log:
  - Provide sensible BROKEN_sparc64 message (it is the same lack of atomics
    implementation that plagues ARM architectures as well)
  - Convert to option helpers, improve wording in option descriptions, and
    spell ``yes'' knob value as we normally do in the ports land

Modified:
  head/textproc/senna/Makefile

Modified: head/textproc/senna/Makefile
==============================================================================
--- head/textproc/senna/Makefile	Sat Dec 23 07:03:21 2017	(r457024)
+++ head/textproc/senna/Makefile	Sat Dec 23 08:13:39 2017	(r457025)
@@ -14,12 +14,12 @@ BROKEN_aarch64=		does not build: libsenna.so: undefine
 BROKEN_armv6=		does not build: libsenna.so: undefined reference to SEN_ATOMIC_ADD_EX
 BROKEN_armv7=		does not build: libsenna.so: undefined reference to SEN_ATOMIC_ADD_EX
 BROKEN_powerpc64=	does not build: relocation truncated to fit: R_PPC64_TOC16_DS
-BROKEN_sparc64=		does not build
+BROKEN_sparc64=		does not build: libsenna.so: undefined reference to SEN_ATOMIC_ADD_EX
 
-GNU_CONFIGURE=	YES
+GNU_CONFIGURE=	yes
 USE_GCC=	any
 USES=		gmake libtool pathfix
-USE_LDCONFIG=	YES
+USE_LDCONFIG=	yes
 CONFIGURE_ARGS=	--with-sennahome=${SENNA_HOME}
 LDFLAGS+=	-lpthread -L${LOCALBASE}/lib
 CFLAGS+=	-I${LOCALBASE}/include
@@ -30,20 +30,12 @@ SENNA_HOME?=	/var/senna
 
 OPTIONS_DEFINE=	MECAB NFKC
 OPTIONS_DEFAULT=	MECAB NFKC
-MECAB_DESC=	use mecab for morphological analysis
-NFKC_DESC=	use nfkc based utf8 normalization
+MECAB_DESC=	Use MeCab for morphological analysis
+NFKC_DESC=	Use NFKC-based UTF-8 normalization
 
-.include <bsd.port.options.mk>
+MECAB_LIB_DEPENDS=	libmecab.so:japanese/mecab
+MECAB_CONFIGURE_OFF=	--without-mecab
 
-.if ${PORT_OPTIONS:MMECAB}
-CONFIGURE_ARGS+=	--with-mecab
-LIB_DEPENDS+=	libmecab.so:japanese/mecab
-.else
-CONFIGURE_ARGS+=	--without-mecab
-.endif
-
-.if ${PORT_OPTIONS:MNFKC}
-CONFIGURE_ARGS+=	--disable-nfkc
-.endif
+NFKC_CONFIGURE_OFF=	--disable-nfkc
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712230813.vBN8DdgF030164>