Date: Fri, 08 May 2015 19:15:22 +0100 From: Matthew Seaman <matthew@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file Message-ID: <554CFD3A.9010005@FreeBSD.org> In-Reply-To: <554CDBE8.7020703@FreeBSD.org> References: <201505081305.t48D5ULi055835@svn.freebsd.org> <CAMHz58SAcjiCprFNT_x0xgg6ceBzhh0s%2BBgYj1uo%2BDQ96rVEyA@mail.gmail.com> <554CD6C9.5000708@FreeBSD.org> <CAMHz58Qk1RfOfh%2BrfaJoFVz5%2B5ij3BxmQQ1a87c2nCtp%2BoBZyA@mail.gmail.com> <554CDBE8.7020703@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QDqRhbTKOl7lA0a8IOc0HsWT2J8oEjAXO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2015/05/08 16:53, Bryan Drewery wrote: > On 5/8/2015 10:43 AM, Sunpoet Po-Chuan Hsieh wrote: >> On Fri, May 8, 2015 at 11:31 PM, Bryan Drewery <bdrewery@freebsd.org >> <mailto:bdrewery@freebsd.org>> wrote: >> >> On 5/8/2015 9:45 AM, Sunpoet Po-Chuan Hsieh wrote: >> > On Fri, May 8, 2015 at 9:05 PM, Matthew Seaman <matthew@freebsd.= org <mailto:matthew@freebsd.org> >> > <mailto:matthew@freebsd.org <mailto:matthew@freebsd.org>>> wrote= : >> > >> > Author: matthew >> > Date: Fri May 8 13:05:29 2015 >> > New Revision: 385776 >> > URL: https://svnweb.freebsd.org/changeset/ports/385776 >> > >> > Log: >> > A data backend for Hiera that can return the content of >> whole files. >> > >> > WWW: https://github.com/adrienthebo/hiera-file >> > >> > Added: >> > head/sysutils/rubygem-hiera-file/ >> > head/sysutils/rubygem-hiera-file/Makefile (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/distinfo (contents, pro= ps >> changed) >> > head/sysutils/rubygem-hiera-file/pkg-descr (contents, >> props changed) >> > Modified: >> > head/sysutils/Makefile >> > >> > Modified: head/sysutils/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- head/sysutils/Makefile Fri May 8 13:02:39 2015 >> > (r385775) >> > +++ head/sysutils/Makefile Fri May 8 13:05:29 2015 >> > (r385776) >> > @@ -836,6 +836,7 @@ >> > SUBDIR +=3D rubygem-hammer_cli_foreman_salt >> > SUBDIR +=3D rubygem-hammer_cli_foreman_ssh >> > SUBDIR +=3D rubygem-hiera >> > + SUBDIR +=3D rubygem-hiera-file >> > SUBDIR +=3D rubygem-librarian-puppet >> > SUBDIR +=3D rubygem-log4r >> > SUBDIR +=3D rubygem-logify >> > >> > Added: head/sysutils/rubygem-hiera-file/Makefile >> > =20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >> > --- /dev/null 00:00:00 1970 (empty, because file is newl= y >> added) >> > +++ head/sysutils/rubygem-hiera-file/Makefile Fri May 8 >> 13:05:29 >> > 2015 (r385776) >> > @@ -0,0 +1,18 @@ >> > +# Created by: Matthew Seaman <matthew@FreeBSD.org> >> > +# $FreeBSD$ >> > + >> > +PORTNAME=3D hiera-file >> > +PORTVERSION=3D 1.1.1 >> > +CATEGORIES=3D sysutils rubygems >> > +MASTER_SITES=3D RG >> > + >> > +MAINTAINER=3D matthew@FreeBSD.org >> > +COMMENT=3D Data backend for Hiera that returns whole = files >> > + >> > +USE_RUBY=3D yes >> > +USE_RUBYGEMS=3D yes >> > +RUBYGEM_AUTOPLIST=3D yes >> > + >> > +RUN_DEPENDS=3D >> > ${PKGNAMEPREFIX}hiera>=3D0:${PORTSDIR}/sysutils/rubygem-hie= ra >> > >> > >> > RUN_DEPENDS should appear earlier. :) >> > >> >> Why? >> >> >> % portlint -abct >> WARN: Makefile: Consider defining LICENSE. >> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. >> 0 fatal errors and 2 warnings found. >=20 > This rule serves no purpose. The port was pretty much cut'n'paste from sysutils/rubygem-hiera. Besides, where in the Makefile would be considered suitable by portlint? Above all the USE_FOO=3D stuff? That's going to generate even worse complaints. Oh, I get it. It thinks the RUBYGEM_AUTOPLIST line should occur later. Except that the rational place to put that is right next to the 'USE_RUBYGEMS' line. portlint isn't guarranteed to be perfect, and in this case, I think it is complaining unnecessarily. Cheers, Matthew --QDqRhbTKOl7lA0a8IOc0HsWT2J8oEjAXO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - https://gpgtools.org iQJ8BAEBCgBmBQJVTP06XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxOUYxNTRFQ0JGMTEyRTUwNTQ0RTNGMzAw MDUxM0YxMEUwQTlFNEU3AAoJEABRPxDgqeTnLCQP/RBSXVMZPEBx3leVsWbouJnb T3H5Bpp2bhP/oQACdZi9xpps9SHEDmL7nz/EcT4/ImHMIxlT+N1dhNa2SgG+eG6L NzlgH4QYBRP7z7kkRpnzbFuocZt+IpZs0WBmNFz2g8xLhnNTipDmTzcIghwI4KK8 T+PLkCUT9x1qvDos8u/BC23OsVV06v6UM3xmlXvZi3x7b0n2xIcjDSzzOE4Lbqz2 zG5aBHkTGYBGyYx/u+yrHdv7LHO4n9/i5O/BkgEyDae4knvn74+m7dHclYfgHT3G O0ALgnWSDL4LZig2FrLs5khcGQxUSHAJXbGmrXdDZCS9mvmptECXPFHVcfLTtoiC 9kkQOlOdoP4mMI8oPH18qY00m04+9Gzh7DEXU2QgC/UcCU+laPPBnVc+46B0YuHN W3kbpxTpDtL/oMqydZ06DyKSyL9po5hEGrEqdJGLmPPE2XZePxDrEn7Gr4w5GfxK iuSxRQ8IY05GT6nEVaDh5OjfpKWHo1911PYuzaP21p5OpK3zu0o2k8DRPiro/gEj AazO9dahaC1ynpYm7QHs2kyWUDUjjGya7Dbny1JTnUhiwrVkkJzoQxZHKj60ATU6 18o4zJOh2Vb/am1sylKw7CgzgVto2qCRDq1ioXKR24vx8c0B+Vn9nQYzR/eUoY2g A+IPPuiTolf72l77q8kj =iGh+ -----END PGP SIGNATURE----- --QDqRhbTKOl7lA0a8IOc0HsWT2J8oEjAXO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?554CFD3A.9010005>