From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 29 10:12:11 2007 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B56116A41A for ; Thu, 29 Nov 2007 10:12:11 +0000 (UTC) (envelope-from stsp@stsp.name) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.freebsd.org (Postfix) with ESMTP id 0C40D13C442 for ; Thu, 29 Nov 2007 10:12:10 +0000 (UTC) (envelope-from stsp@stsp.name) X-Envelope-From: stsp@stsp.name Received: from stsp.lan (stsp.in-vpn.de [217.197.85.96]) (authenticated bits=128) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id lATAAew7007892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 29 Nov 2007 11:10:41 +0100 Received: from ted.stsp.lan (localhost [127.0.0.1]) by stsp.lan (8.13.8/8.13.8) with ESMTP id lATAAeYU002395; Thu, 29 Nov 2007 11:10:40 +0100 (CET) (envelope-from stsp@ted.stsp.lan) Received: (from stsp@localhost) by ted.stsp.lan (8.13.8/8.13.8/Submit) id lATAAdLn002394; Thu, 29 Nov 2007 11:10:39 +0100 (CET) (envelope-from stsp) Date: Thu, 29 Nov 2007 11:10:39 +0100 From: Stefan Sperling To: Sam Leffler Message-ID: <20071129101039.GE1513@ted.stsp.lan> References: <20071125174204.GT1463@ted.stsp.lan> <452840.43857.qm@web38013.mail.mud.yahoo.com> <20071125214850.GY1463@ted.stsp.lan> <200711281613.lASGDSui016057@fire.js.berklix.net> <20071128180618.GC22259@jack.stsp.lan> <474DB348.4060803@errno.com> <20071128184545.GD22259@jack.stsp.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n+lFg1Zro7sl44OB" Content-Disposition: inline In-Reply-To: <20071128184545.GD22259@jack.stsp.lan> User-Agent: Mutt/1.5.16 (2007-06-09) X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 Cc: hackers@freebsd.org Subject: presenting WOL to the user (was: Re: How to add wake on lan support for your card) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2007 10:12:11 -0000 --n+lFg1Zro7sl44OB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 28, 2007 at 07:45:45PM +0100, Stefan Sperling wrote: > On Wed, Nov 28, 2007 at 10:28:24AM -0800, Sam Leffler wrote: > > I really want to see the WOL support get into the tree. >=20 > Cool. >=20 > > I looked at it=20 > > before and had some issues with ifconfig integration which is mostly wh= y=20 > > it's not already there. >=20 > You mean you are hacking on it as well (independently) > or you were trying my patch? Sam, nevermind that question of mine. I thought about this again. I suppose you have issues with the way I made ifconfig present WOL information to the user? $ ifconfig vr0 vr0: flags=3D8943 mtu 1500 inet 10.42.42.2 netmask 0xffffff00 broadcast 10.42.42.255 ether 00:0b:6a:d5:1e:b1 media: Ethernet autoselect (100baseTX ) status: active ---> supported wake events: unicast magic ---> will wake on: magic Adding two new lines of output for a minor feature like that is indeed overkill. Actually I have been thinking about this for a while. Maybe the WOL information should somehow be integrated into interface flags? There would be quite a few wake on lan options to be squeezed into the flags though: magic packet, link status, unicast, broadcast, multicast (at least). This would look somewhat like: vr0: flags=3DXXXX mtu 1500 Would that be better? I don't know how crowded the flag bit space already is though, because I had no time to look at it yet. How do you think could the available WOL options be presented to the user? Clearly flags can't be used for this. Maybe we should simply drop this functionality, and operate like the ifconfig "polling" option -- simply return an error if the interface does not support the requested WOL event, but don't provide other means of finding out what it does actually support? Or should we introduce a special ifconfig subcommand to query this information? Has anyone got better ideas? Thanks, --=20 stefan http://stsp.name PGP Key: 0xF59D25F0 --n+lFg1Zro7sl44OB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHTpAf5dMCc/WdJfARAsKPAJoC57tzmvbd7rOC84JLTLEYMQQIywCg52gg MrLZDk0XgZoAN1OFZH7kzm0= =7rap -----END PGP SIGNATURE----- --n+lFg1Zro7sl44OB--