Date: Wed, 23 Mar 2022 17:05:18 +0300 From: Vasily Postnicov <shamaz.mazum@gmail.com> To: Baptiste Daroussin <bapt@nours.eu> Cc: Muhammad Moinur Rahman <bofh@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: What to do if e-mail from pkg-fallout@freebsd.org arrives? Message-ID: <CADnZ6BkF1c8wS3DA-4=7-fP=C7OjM8_s6c6k2UEsjiAJgKXLJg@mail.gmail.com> In-Reply-To: <20220323135659.s4ameibeobk7tft7@aniel.nours.eu> References: <CADnZ6BnKMOvwya=gkhaAnKxu-cPtC=bp-cz5aZ3nNRXZi9U9Og@mail.gmail.com> <90949B3A-DB76-485B-BA14-425849635B49@freebsd.org> <CADnZ6BkWxg1FSbLN8_gecKjMSd1-wMNqy4AiUgUQ_NcFRejd_A@mail.gmail.com> <20220323135659.s4ameibeobk7tft7@aniel.nours.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000dc362005dae33844 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Lol, I've just checked the source code. And voil=C3=A0, va_list is gone in master :) I was really confused why I cannot reproduce that bug on my machine, didn't see the log was for arm. Thank you all! =D1=81=D1=80, 23 =D0=BC=D0=B0=D1=80. 2022 =D0=B3. =D0=B2 16:57, Baptiste Da= roussin <bapt@nours.eu>: > On Wed, Mar 23, 2022 at 04:44:29PM +0300, Vasily Postnicov wrote: > > Oh my! I didn't see that. I tried on x86-64 :) I don't even have arm64 > > machine. Any ideas what to do? > > > > Communicate with upstream to see if they are aware of such a build issue > (providing them the build error) in their cases they will probably say > "yes sure > that rings a bell we got rid of this issue a year and a half ago) > > > https://github.com/Interrupt/systemshock/commit/81804761044593a22aeba6b6a= 3a7af56465f5153 > > (Side note: I am not claiming you should have guessed this could be a > potential > fix, but upstream should be able to point you at this patch). > > Since they haven't issue a release since they commit that you can try > backporting that patch into your port, praying that the patches applies, > if it > does, test that your port still works on plateform you can actually test > on, and > open a PR with the said patch applied). > > if it fixes the issue pkg-fallout should not bother you anymore, if not, > then > the investigation needs to be pursued. > > > Hope it helps, > > Best regards, > Bapt > > --000000000000dc362005dae33844 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Lol, I've just checked the source code. And voil=C3=A0= , va_list is gone in master :)<div><br></div><div>I was really confused why= I cannot reproduce that bug on my machine, didn't see the log was for = arm.</div><div><br></div><div>Thank you all!</div></div><br><div class=3D"g= mail_quote"><div dir=3D"ltr" class=3D"gmail_attr">=D1=81=D1=80, 23 =D0=BC= =D0=B0=D1=80. 2022 =D0=B3. =D0=B2 16:57, Baptiste Daroussin <<a href=3D"= mailto:bapt@nours.eu">bapt@nours.eu</a>>:<br></div><blockquote class=3D"= gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border= -left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On W= ed, Mar 23, 2022 at 04:44:29PM +0300, Vasily Postnicov wrote:<br> > Oh my! I didn't see that. I tried on x86-64 :) I don't even ha= ve arm64<br> > machine. Any ideas what to do?<br> > <br> <br> Communicate with upstream to see if they are aware of such a build issue<br= > (providing them the build error) in their cases they will probably say &quo= t;yes sure<br> that rings a bell we got rid of this issue a year and a half ago)<br> <br> <a href=3D"https://github.com/Interrupt/systemshock/commit/81804761044593a2= 2aeba6b6a3a7af56465f5153" rel=3D"noreferrer" target=3D"_blank">https://gith= ub.com/Interrupt/systemshock/commit/81804761044593a22aeba6b6a3a7af56465f515= 3</a><br> <br> (Side note: I am not claiming you should have guessed this could be a poten= tial<br> fix, but upstream should be able to point you at this patch).<br> <br> Since they haven't issue a release since they commit that you can try<b= r> backporting that patch into your port, praying that the patches applies, if= it<br> does, test that your port still works on plateform you can actually test on= , and<br> open a PR with the said patch applied).<br> <br> if it fixes the issue pkg-fallout should not bother you anymore, if not, th= en<br> the investigation needs to be pursued.<br> <br> <br> Hope it helps,<br> <br> Best regards,<br> Bapt<br> <br> </blockquote></div> --000000000000dc362005dae33844--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADnZ6BkF1c8wS3DA-4=7-fP=C7OjM8_s6c6k2UEsjiAJgKXLJg>