From owner-svn-ports-head@FreeBSD.ORG  Fri Mar 22 01:56:09 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id D7ABC364; Fri, 22 Mar 2013 01:56:09 +0000 (UTC)
Date: Fri, 22 Mar 2013 01:56:09 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Beech Rintoul <beech@FreeBSD.org>
Subject: Re: svn commit: r314866 - head/graphics/piddle
Message-ID: <20130322015609.GB17285@FreeBSD.org>
References: <201303211953.r2LJrG9c004938@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201303211953.r2LJrG9c004938@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Mar 2013 01:56:09 -0000

On Thu, Mar 21, 2013 at 07:53:16PM +0000, Beech Rintoul wrote:
> New Revision: 314866
> URL: http://svnweb.freebsd.org/changeset/ports/314866
> 
> +.if ${PORT_OPTIONS:MDOCS}
> +	(cd ${WRKSRC}/docs && ${COPYTREE_SHARE} \* ${DOCSDIR})

May I bring your attention one more time to the fact that using a dot
instead of asterisk has several advantages while achieving the same thing:

  - dot is not a subject to shell expansion, thus being generally safer
  - consequently, dot does not have to be escaped
  - dot is one character shorter and more readable (escaping commonly
    reduces readability in Unix constructs)

I think I've already made similar observations few days ago, which somehow
went unanswered.  If there's a flaw in my reasoning, please speak up, thanks!

./danfe