From owner-freebsd-python@freebsd.org Wed Dec 5 03:25:49 2018 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8A6D132B907 for ; Wed, 5 Dec 2018 03:25:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4AB38810AD for ; Wed, 5 Dec 2018 03:25:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 08671132B8FE; Wed, 5 Dec 2018 03:25:49 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0EEF132B8FD for ; Wed, 5 Dec 2018 03:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5860F810A9 for ; Wed, 5 Dec 2018 03:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 77A7E8558 for ; Wed, 5 Dec 2018 03:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wB53PlEA067897 for ; Wed, 5 Dec 2018 03:25:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wB53PlAs067896 for python@FreeBSD.org; Wed, 5 Dec 2018 03:25:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 233781] devel/py-freebsd: Update to 0.9.4, Fix with python 3.x support Date: Wed, 05 Dec 2018 03:25:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? X-Bugzilla-Changed-Fields: flagtypes.name bug_severity cc bug_status short_desc keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 4AB38810AD X-Spamd-Result: default: False [-0.05 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.18)[-0.179,0]; NEURAL_SPAM_LONG(0.03)[0.034,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.10)[0.096,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 03:25:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233781 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |maintainer-feedback?(soboma | |x@FreeBSD.org) Severity|Affects Only Me |Affects Some People CC| |koobs@FreeBSD.org, | |sobomax@FreeBSD.org Status|New |Open Summary|devel/py-freebsd: fix with |devel/py-freebsd: Update to |python 3.x and upgrade to |0.9.4, Fix with python 3.x |version 0.9.4 |support Keywords| |needs-patch, needs-qa --- Comment #2 from Kubilay Kocak --- Thank you Maxim. A couple of review items: 1) GH_TAGNAME=3D v${PORTVERSION} - Use DISTVERSIONPREFIX=3Dv, drop GH_TAGN= AME 2) Can you provide detail or explanation (and include in the commit message after approval) of: a) the upstream change. Is it a fork, did you transfer/coordinate with perk= y to move it to GitHub? b) The patch removals. Were they upstreamed? No longer necessary? 3) Since it appears the upstream is not hosted under your GitHub account, w= ould you like to update MAINTAINER to yourself? Please include that change if so. 4) The package includes tests. Can you add TEST_DEPENDS (if necessary) and a test target to run them. Ideally this should be integrated upstream, using setup.py test (setup.py:tests_require,test_suite, et al) 5) Was Python 3 support supposed to work prior to this, but was broken? Or = was Python 3 support recently added upstream and in this version? If the latter, update the issue summary (and commit log message) to say 'Enable Python3.x support' rather than 'Fix Python 3.x support' Longer term (not for this commit), can we look at distributing/publishing t= his to PyPI (CHEESESHOP). In particular, it would be good to have a 'registered' and canonical name for this package. Right now the portname is 'freebsd', b= ut the actual upstream / distname is 'py-freebsd'. I'd go with just 'freebsd' = for PyPI, to match the current PORTNAME. It doesn't ultimate matter what the re= po name is. --=20 You are receiving this mail because: You are the assignee for the bug.=