From nobody Wed Jul 1 10:00:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqwVd2y3mz6jyN8; Wed, 01 Jul 2026 10:00:09 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqwVd1ndLz3fk4; Wed, 01 Jul 2026 10:00:09 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782900009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GTbeh0L/RDB0alZIJzbqV2+izdG85Oc4z9lHU5Tz5c=; b=FTHqW1qFDlVBfrUTkItssCWnoP8G4vVWDpRXDMuRUXcPP1hv0wftt4zTX7Y+OYkKldFKQZ NjJxI9iQqZCip31bZNlyS8qvY6J8hgVe9KRarjICxOnRibN9/TUQRRIjMOBbJO9YAowsvM ASHCP1Sg0I3ZMdUToNS2s1t3TiHIYCkjiPu42xLeR3eVXdNIj2sddoh+brfQ+B8oVrt2DC cNk6OfO26OoV9DkkfGLepAzlGqMiFDIyFLj0HEhNqWWtVMjZtj5aZrOTKUB2LKrwl07CS9 SCQQ5QyO4DjYNv6YlHLkIKipNmLGd/hLf2geNZBbe3QshLZ44E8bHnSpM5e8kg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782900009; a=rsa-sha256; cv=none; b=Qc50Ny3n3YOiFWSWsOkOPqEVWkTtcHLhrgvtsae4SAmXW/9btgoCYR1yzl7eOPUy12Fndb w05YKnRWH4ZIQdnnPWJEpzdTw0Nx3NUDdPXFfFoiBhqeNP1xXzcZotjEpLL7SQJ7KhltxT kOh9HbVzpmNOG5qZsW6RceqL14TUMN+NUq03qfD7wDE625od5lRocrJDFIRaU7DTbpDmiU +7YDY5ktfIj8+FqgUTtCEinN1GrsJgrO8mKxWIgUL0q9cfjEHk0IJRkak/WXZirE95qaNk 0WDdZElUVHIhR3lo7fzBjjTf9miqEzcS15JdXzKuuWmQ1RJzuoyEL8thlN8k/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782900009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GTbeh0L/RDB0alZIJzbqV2+izdG85Oc4z9lHU5Tz5c=; b=lV2xRzPQ9+mvTe9nYkGaG2IFdop19i6L//hcZJLVN+B6qUBW2fUwjfcvk0/SBWEPF3QgBz eb/sj5OSXpDLoxL6DMitN4VhDRC7tYZ/82XUrWVtUuMDmBobNNZ30Ox0AxZRkvFn0d0dIh nRWSFcC9mkcpuTwcs3/LXevfCgIg5189FTUce3JUsMLcIwp5UA9Bd7y4kYh67D02iZLzip Bp4+Hxal/jLaswo8aLdawhi2JmdDuq2X90iXBfy2siX40sRmx8iMZkB8vfvGhxqGxQArjx io8JvxYxxaKybctS7A3UWioGglP6PBBLpxVA5I41fuhb7Z2Bzmc3lsSVCI1dDw== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:2563:add6:d31:5619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gqwVc2txYz19BQ; Wed, 01 Jul 2026 10:00:08 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: d6c4cea7740d - main - loopback: improve checksum offloading From: Michael Tuexen In-Reply-To: Date: Wed, 1 Jul 2026 12:00:05 +0200 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?utf-8?Q?Timo_V=C3=B6lker?= Content-Transfer-Encoding: quoted-printable Message-Id: References: <6a40fe36.39b1d.3aea7fb1@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3864.600.51.1.1) > On 1. Jul 2026, at 06:16, Gleb Smirnoff wrote: >=20 > On Sun, Jun 28, 2026 at 10:57:58AM +0000, Michael Tuexen wrote: > M> commit d6c4cea7740d5c5c673a06ba37e4f1bdcddb2ece > M> Author: Timo V=C3=B6lker > M> AuthorDate: 2026-06-28 10:50:15 +0000 > M> Commit: Michael Tuexen > M> CommitDate: 2026-06-28 10:50:15 +0000 > M>=20 > M> loopback: improve checksum offloading > M> =20 > M> * Allow disabling IFCAP_RXCSUM_IPV6 or IFCAP_TXCSUM_IPV6. > M> * Do not pretend the checksum is correct by setting the = LO_CSUM_SET > M> flags if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is enabled. = Instead, > M> remove the LO_CSUM_SET flags (in case they have been set = somehow) > M> if IFCAP_RXCSUM_IPV6 or IFCAP_RXCSUM is disabled. > M> * Do not unset the transmit checksum offload flags = LO_CSUM_FEATURES or > M> LO_CSUM_FEATURES6 since they now have a meaning for the = receive path. > M> =20 > M> Reviewed by: glebius, pouria, tuexen > M> Okayed by: bz > M> MFC after: 1 week > M> Differential Revision: https://reviews.freebsd.org/D57518 >=20 > I'm guessing this change is responsible for breaking the > netinet/ip_reass_test. The tests inject packets to localhost. Now all > subtests fail, but after each test that creates single packet I see in = 'netstat > -sp ip' increase in 'bad header checksums'. >=20 > Can you please check this? The checksum is not correctly computed in the tests and after the above = patch this is not ignored anymore. A patch is under review: https://reviews.freebsd.org/D57988 Best regards Michael >=20 > --=20 > Gleb Smirnoff