From nobody Tue Sep 2 20:42:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cGd2m4tkqz65PfF; Tue, 02 Sep 2025 20:42:08 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cGd2m3dlNz3wn6; Tue, 02 Sep 2025 20:42:08 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756845728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FIukxloxVtZFe5mJBGy/PK30W0GxYuvvVzmfXPHQns4=; b=nSuGg/938i557fdI2jjxMjZj4qprPXyH0CPwXU2xSx3Ch+QBjAnfAJ03Yoyx/dAm2mZ1lX 5d79H+TBHzp2CppKEkSOef8pQZDuJaF2rloIsgP3dcU/2iW0JAoFiBVend3BqB7lXygYPT YG8zPC8/Pz1qVCOgpQIUj6lui5zC0X+XGM40zXbqWVBKikmXSYlslpSBMpIbeAPq05+Ug8 jo1m0yMhXxTszU9bIZyD7IuYxthb2pFz26WB22783Nyksz4R+uRalvgLb0l/CjIhiO6DsJ BMroc+A9zN7x21A/9kMJ8v099ZGLhEpGdRzp+ssKjCubeY9l1kGFAvVfGh8c6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756845728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FIukxloxVtZFe5mJBGy/PK30W0GxYuvvVzmfXPHQns4=; b=rlU4accaini9gxSzz1SW+jrRk/1TJ8suZumKU/HNDrv0VMFw8FGiUpXwPFqdjUQmbRu1jW eF7cAKGV5BCVYKgdtqYIUuewlsPdjK4ZBYn0HOn1pmtVpd5fdN16KWDhcR8Nu7RJq5GK0n COkhoNEbSI70DX1rOmvHPzwwI4sWGiD+DIDz8kmqMsv+YCUL5WxprQaYETtiqdOxjRntBO Yz7mfegScWX612SminEKJpsx/XwJnU09tishfmDJ5ReXXbWkkNQFc8gPcDfoQH83SMlM6T Wgw13m9o7/xiTm+mCGWp6bKSQ67P1ztkhTUykwnEKFMtwzcs04xnyWKR3FXmLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756845728; a=rsa-sha256; cv=none; b=G2pWZIJ1jgrKmEqFei8+fcZGP/kaE7z1MYSz28ekEZdo2iVCOLEj/HS9vqfMLxr87vC1WV QAb9YP3keW4Tf4i5Vl/09sYcdBKbvrHGyxsBrKcRPq8rlzxJ29pUipmvy5XlQFLnAFEB7z PnS68dxyITWy4ho/Y0smnX7jbEaMrXprLmWFjGdYfTebLv3Ab/odKqjRyjoz3xI5U75nPb IjjBSPLoyLnEBc806sdmg1HauDXp/kBBvVuLB0f6qIAeGCWG5I0EzBAUNYAFyTw//ZcKu3 9L1zf25V2WYY5TqMiaWHT4lCc7fF9Ano53wCuyXEUDcoWf9Uin55uOWxb99sRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:11fc:b4c1:77db:722e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cGd2l6hCMznCr; Tue, 02 Sep 2025 20:42:07 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: e4ea162509e4 - main - epair: add support for checksum offloading From: Michael Tuexen In-Reply-To: <1781EA53-EA6F-456B-B69D-74243A13F3FC@FreeBSD.org> Date: Tue, 2 Sep 2025 22:42:06 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202509012217.581MHwPo033928@gitrepo.freebsd.org> <1781EA53-EA6F-456B-B69D-74243A13F3FC@FreeBSD.org> To: Kristof Provost X-Mailer: Apple Mail (2.3826.700.81) > On 2. Sep 2025, at 22:10, Kristof Provost wrote: >=20 > On 2 Sep 2025, at 0:17, Michael Tuexen wrote: > The branch main has been updated by tuexen: > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De4ea162509e400340a2bc3e755071a92= f3465e2d > commit e4ea162509e400340a2bc3e755071a92f3465e2d > Author: Timo V=C3=B6lker timo.voelker@fh-muenster.de > AuthorDate: 2025-09-01 22:03:47 +0000 > Commit: Michael Tuexen tuexen@FreeBSD.org > CommitDate: 2025-09-01 22:15:51 +0000 > epair: add support for checksum offloading >=20 > Add capabilities RXCSUM and RXCSUM6 as well as TXCSUM and TXCSUM6 for > for receive and transmit checksum offloading for TCP and UDP to the > epair interface and enable them by default. > RXCSUM and RXCSUM6 are enabled because an epair interface may receive > a packet with the csum_flag CSUM_DATA_VALID set, which is expected > only if these capabilities are enabled. Since it seems not helpful to > remove this flag, it is not possible to disable these capabilities. > TXCSUM and TXCSUM6 are synchronized between the two epair interface > ends. If enabled/disabled on one end, it will be enabled/disabled on > the other end. If the sending epair interface end has TXCSUM or = TXCSUM6 > enabled and the receiving end is in a bridge, it is assumed that all > interfaces in the bridge have that capability enabled. Otherwise the > bridge would have disabled that capability on the receiving epair > interface end in the bridge which would have disabled that capability > on the sending epair interface end as well due to the synchronization. >=20 > Reviewed by: bcr, Seyed Pouria Mousavizadeh Tehrani > MFC after: 4 weeks > Differential Revision: https://reviews.freebsd.org/D51639 >=20 > This seems to be causing a lot of pf test failures, especially in the = route_to tests. > All of these now fail, unless this commit is reverted: I have reverted the commit. We will investigate what is going wrong. Thank for the report! Best regards Michael > nat:binat_compat -> failed: atf-check failed; see the output of the = test for details [4.423s] > nat:binat_match -> failed: atf-check failed; see the output of the = test for details [7.535s] > nat:nat_match -> failed: atf-check failed; see the output of the test = for details [4.511s] > nat:nat_pass -> failed: atf-check failed; see the output of the test = for details [7.337s] > nat64:tcp_in_floating -> failed: Failed to connect to TCP server = [6.142s] > nat64:tcp_in_if_bound -> failed: Failed to connect to TCP server = [6.048s] > nat64:tcp_out_floating -> failed: Failed to connect to TCP server = [6.268s] > nat64:tcp_out_if_bound -> failed: Failed to connect to TCP server = [6.253s] > nat64:udp_in -> failed: Failed to connect to UDP server [6.097s] > nat64:udp_out -> failed: Failed to connect to UDP server [6.071s] > rdr:tcp_v6_compat -> failed: 0 !=3D 22 ( 0 !=3D 22) [2.736s] > rdr:tcp_v6_pass -> failed: 0 !=3D 23 ( 0 !=3D 23) [1.978s] > route_to:prefer_ipv6_nexthop_ipv4_random_prefix_ipv4 -> failed: = atf-check failed; see the output of the test for details [5.693s] > route_to:prefer_ipv6_nexthop_ipv4_random_table_ipv4 -> failed: = atf-check failed; see the output of the test for details [12.511s] > route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv4 -> failed: = atf-check failed; see the output of the test for details [14.865s] > route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv6 -> failed: = atf-check failed; see the output of the test for details [7.849s] > route_to:prefer_ipv6_nexthop_mixed_af_random_table_ipv4 -> failed: = atf-check failed; see the output of the test for details [11.843s] > route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv4 -> failed: = atf-check failed; see the output of the test for details [5.566s] > route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv6 -> failed: = atf-check failed; see the output of the test for details [11.089s] > route_to:prefer_ipv6_nexthop_single_ipv4 -> failed: atf-check failed; = see the output of the test for details [6.615s] > route_to:prefer_ipv6_nexthop_single_ipv6 -> failed: atf-check failed; = see the output of the test for details [7.210s] > route_to:random_prefix -> failed: atf-check failed; see the output of = the test for details [6.608s] > route_to:random_table -> failed: atf-check failed; see the output of = the test for details [6.513s] > route_to:roundrobin -> failed: atf-check failed; see the output of the = test for details [6.248s] > route_to:table_loop -> failed: atf-check failed; see the output of the = test for details [6.606s] > src_track:max_src_conn_rule -> failed: atf-check failed; see the = output of the test for details [4.743s] > src_track:max_src_states_global -> failed: atf-check failed; see the = output of the test for details [5.010s] > src_track:max_src_states_rule -> failed: atf-check failed; see the = output of the test for details [5.026s] > src_track:mixed_af -> failed: atf-check failed; see the output of the = test for details [5.532s] >=20 > Best regards, > Kristof