Date: Tue, 29 Jun 1999 21:50:02 -0700 (PDT) From: Tim Vanderhoek <vanderh@ecf.utoronto.ca> To: freebsd-ports@FreeBSD.org Subject: Re: ports/12457: lots of bsd.port.mk code executed needlessly Message-ID: <199906300450.VAA78285@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/12457; it has been noted by GNATS.
From: Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To: mi@aldan.algebra.com
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/12457: lots of bsd.port.mk code executed needlessly
Date: Wed, 30 Jun 1999 00:48:25 -0400
On Tue, Jun 29, 1999 at 10:52:30PM -0400, Mikhail Teterin wrote:
>
> This is also underlined by another bsd.port.mk's deficiency,
> which makes it reexecute make recursively and linearly
> several times for a simple target like fetch, instead of
> using the dependecies more.
No, you don't understand how bsd.port.mk works.
Actually, there's a very strong possibility that using dependencies
more would make it slower, not faster.
> -.if defined(MLINKS)
> +.if make(compress-man) && defined(MLINKS)
> __pmlinks!= ${ECHO} '${MLINKS:S/ / /}' | ${AWK} \
> @@ -1128,3 +1128,3 @@
Your patch breaks if you use dependencies more, as you just suggested
a couple paragraphs ago. There's also a problem that is sufficiently
glaringly obvious as to show that you haven't tested this much... :-)
Look, sorry for being terse, but it's almost 1:00am right now. Before
running off and filing a bug-report, I'm going to suggest that next
time you wait just a little while, especially given the first line I
wrote...
Sorry,
--
This is my .signature which gets appended to the end of my messages.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199906300450.VAA78285>