From nobody Tue Jul 22 04:11:48 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bmP3T3618z62P5r; Tue, 22 Jul 2025 04:11:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bmP3T15zZz3pvW; Tue, 22 Jul 2025 04:11:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753157509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0KvH45sHHDKY9vRE4qifQchefyzG6RA81h8Wz+m51ig=; b=JHzo7YCEnd3+J+tc+tcA/dI1Z19nVD8bIyBGU04mwvBsCb/jeB04pvAIUEGyVHBt8E8P61 LOCKLpURNzUsDMXxHRrLgfw/rugL3+tZEc8q4nNiYoyyD84HFlS1kq+6w3Tfd9XkB+dfEk pxsEk/c/gnMFURNSZ0YkPQZ6Ij/DaVLWTqooSdL9vO//KIHav+PmLXx2ODI75nHKLErOSJ F1FGl74TaZy6+pnOuQPGHw5CgCSMBURtQoN0ZVpTMGbndfcmRkw+cSQkpRgfhwYpTFjC6C pn4I3Q9BeENumdETnneAtrxNAubgAfCUA4Ecv+d8o6wbaupWrn6fgAe2N5HkSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753157509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0KvH45sHHDKY9vRE4qifQchefyzG6RA81h8Wz+m51ig=; b=avYGu5mVPPLmFeSqL8cQO5ShHFbDja/CpWJ6wsYROrXNBfKWJlfM6s587j7WJQoEThtmly qZeA4N/kCddxkGwvSNOTE0f2im+SjbVuBJJVHPy3VtzUGAKn2i1PLEDoLbvlmwLr/LFnvk +fFC1P/WWsfg9XjHtBEMCiB2XhIN1VB4Svt8KWdzHbHP0QJ4zi1u097DOXCsbEwbVo3zxk F3QUShCDrxNjrt8WV/yce6R+DbPlPXBNVuO9Fhjb5gaZ+VwUbIJgARM9vxk5/eVehXh7NF kn127udQ2/Vi4XYFdPZtmVTjf+At2xfuttvU3LQFwhX41M3vdsuOp70UphqxKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753157509; a=rsa-sha256; cv=none; b=QJDL++mw6v0qG47EI6ucpmiDRCGZQ5UH1R+bzX85PH+V/R8Y72ZUqb1h64pMVC8gBNQyKd Uwyk7dOuhA39ttvwlhaT6Wn6mPxHHOCVPbVNsUDp+5LiMirFcSG9FJbCwQ1wsizy6tbjNl P4ryh08O73yzPywY6ChhyChWoqG07wkBOrK8n5zJ/QDUwse0aFy/Og9Oq2efDwLXgNivNv itZ+flridbdrheYqk3fsFoCtNIIq1dTS+DrBMhYG1Su/Qf1LY6tpeSUqDcDBgUMghXxYQf CeGVQeyArAnBR0/bmFirHXRW/GdhG3WS8/wc9RvmXHWNfsD38d+i78Rkd/DDBg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bmP3T0gg3z1QrR; Tue, 22 Jul 2025 04:11:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56M4BmNa056397; Tue, 22 Jul 2025 04:11:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56M4Bmie056394; Tue, 22 Jul 2025 04:11:48 GMT (envelope-from git) Date: Tue, 22 Jul 2025 04:11:48 GMT Message-Id: <202507220411.56M4Bmie056394@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: c18860339d50 - main - qlnxe: Fix advertising the IFCAP_LINKSTATE capability List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c18860339d5051dea99cb5cee7e322ffa5dd2a81 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=c18860339d5051dea99cb5cee7e322ffa5dd2a81 commit c18860339d5051dea99cb5cee7e322ffa5dd2a81 Author: Zhenlei Huang AuthorDate: 2025-07-22 04:11:02 +0000 Commit: Zhenlei Huang CommitDate: 2025-07-22 04:11:02 +0000 qlnxe: Fix advertising the IFCAP_LINKSTATE capability The following up advertising of IFCAP_HWCSUM capability unconditionally overwrite IFCAP_LINKSTATE. Reviewed by: kbowling MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D51450 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 9d23d5df1d2b..60e807d55e01 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2308,8 +2308,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) else if (device_id == QLOGIC_PCI_DEVICE_ID_1644) if_setbaudrate(ifp, IF_Gbps(100)); - if_setcapabilities(ifp, IFCAP_LINKSTATE); - if_setinitfn(ifp, qlnx_init); if_setsoftc(ifp, ha); if_setflags(ifp, IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST); @@ -2343,7 +2341,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) if_setcapabilities(ifp, IFCAP_HWCSUM); if_setcapabilitiesbit(ifp, IFCAP_JUMBO_MTU, 0); - if_setcapabilitiesbit(ifp, IFCAP_VLAN_MTU, 0); if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWTAGGING, 0); if_setcapabilitiesbit(ifp, IFCAP_VLAN_HWFILTER, 0); @@ -2352,6 +2349,7 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) if_setcapabilitiesbit(ifp, IFCAP_TSO4, 0); if_setcapabilitiesbit(ifp, IFCAP_TSO6, 0); if_setcapabilitiesbit(ifp, IFCAP_LRO, 0); + if_setcapabilitiesbit(ifp, IFCAP_LINKSTATE, 0); if_sethwtsomax(ifp, QLNX_MAX_TSO_FRAME_SIZE - (ETHER_HDR_LEN + ETHER_VLAN_ENCAP_LEN));