From nobody Sat Apr 18 20:06:17 2026 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fyjSD2QGGz6ZBbk; Sat, 18 Apr 2026 20:06:20 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fyjSD1fdNz3KLX; Sat, 18 Apr 2026 20:06:20 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776542780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sG90c32W4vnIW2Jit9KvcUOAawZmByROHUdjW7zZraE=; b=rR2hEbcxaRkmQBa1UyJ2IYCFFbe898wdZa4ncpw604/DHSRZFOo7ND2egJBPW3tbUBTH5z 6uOK5T5/sbkXMsBzw/sS3mgiRCEK5o3TDJvJZMXa1Jo5TdP9+l/4/geBA5B9EUXliVqa7Z 0SS+w17efHtd9k67I5Xhf4tsXk9WGDSQU0gxcA+f0ILwG0zWsYF26hOnO6SuXTBxlIZeDk ocWwyP0K1tZiZxqr0oAeIBfna4QMsUhGwdGa83F9rii4K9+wsgCNKWYIWqIpHI2EwbWrkt wzha5Unoqjvx+9JUPguPZQJQraXBPW6Dz3FRGPZjOASEijSqiPEJWzrO5h0o8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776542780; a=rsa-sha256; cv=none; b=A7WNAhJb6Bha8B0Ek7ugPmyyB7eOUMFZXqW8S4dmmMGL/NwW/CXt/UXplftmB7qOwCj0Y4 TQs0WGhyXeA8UEuehFBv6e5yK/N0/ID+E5ECFdO0RBzw7Q462bcEDqkARp/4Z7NPnUxexp IazTEIvYEGJAYyKPJZRK+KC9uwkU2hjpQeUrYKh9XmP5ogNlVjRHe6GFxtWAii9gnewXbS f52YwOVJWvgK8XTpRkKEWQjkGTGDnew9JRztzTvzJnbbBVDbhrdgyTzwFru9Wbh4/ovHAI J0rIVwSnFX3YHPARWBAgTZQqzprsSIbgDGm3IXbFDC/OciSBqeW1etVkarKN9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776542780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sG90c32W4vnIW2Jit9KvcUOAawZmByROHUdjW7zZraE=; b=BgRyyVoT/MBg+/tj5E6mn/lqu3mrV/ote50T+3//prlDQSRRTUsR24A7TzygZAXNoxYp6a Z06I8udo77o7gPzY8L1zr3FXAej78hj/nY/dxCazrQjEz8OxIfLkQdnbgFdz1p6Yhc7ggK gIOe0apDd8roB7tMt5VnSvEVHLmxX4Fk9WURNIcV6ZsnDPSS5wsLdhrlW3cVXVu19DDMhA vMSRaoDdFjWZ2v3yKtg0cIZe6NYcgtsw9RMe1lygWRXdWFAQqQQFhacABS/xR6Ld0rEcMt I9MgKeuXyk8SQ2b9cwA89xneeHL387V5+AdqTxyylK4SuLPMZsxaTKCo+sNu+Q== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:d835:7117:6c6b:190a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fyjSC4L1ZzKXx; Sat, 18 Apr 2026 20:06:19 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\)) Subject: Re: panic: assertion failed in iflib_txq_drain() From: Michael Tuexen In-Reply-To: Date: Sat, 18 Apr 2026 22:06:17 +0200 Cc: current@freebsd.org, Ricardo Branco , freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <9d640ae4-7133-4d4f-917f-d715ab71ee7b@suse.de> <3b60c3e6-f53f-4084-a435-fe5371c56e58@app.fastmail.com> To: Drew Gallatin X-Mailer: Apple Mail (2.3864.500.181) > On 18. Apr 2026, at 21:51, Drew Gallatin wrote: >=20 >=20 > That is indeed the proper fix. I just reviewed & tested it. Thank = you so much! Thanks for the quick review. The fix is committed in: = https://cgit.FreeBSD.org/src/commit/?id=3Dcca22c36c306dfabe13b1d1de10e8d27= ef3c3bce = Best regards Michael >=20 > Until it lands, another workaround is to use the new, cheaper, faster, = simpler iflib transmit routine by setting the tunable >=20 > dev.$NIC.$UNIT.iflib.simple_tx=3D1 >=20 > Eg, dev.bnxt.0.iflib.simple_tx=3D1 >=20 > In loader.conf >=20 > I plan to deprecate the current complex transmit routine (mp_ring) in = favor of the simple mechanism, and I confess that I sometimes don't test = "straightforward" changes like this on mp_ring. I'll try to get better = about that. >=20 > Drew >=20 > On Sat, Apr 18, 2026, at 3:12 PM, Michael Tuexen wrote: >>=20 >>=20 >> > On 18. Apr 2026, at 21:09, Drew Gallatin = wrote: >> >=20 >> > Sorry, looking into this now. I did not test this change with the = mp_ring path.. i don't see how fixing the counters could cause this = panic. Looking at it now.. >> Hi Drew, >>=20 >> I think https://reviews.freebsd.org/D56509 fixes it. >>=20 >> Best regards >> Michael >> >=20 >> > Drew >> >=20 >> > On Sat, Apr 18, 2026, at 1:38 PM, Michael Tuexen wrote: >> >>=20 >> >>=20 >> >> > On 18. Apr 2026, at 19:14, David Wolfskill = wrote: >> >> >=20 >> >> > On Sat, Apr 18, 2026 at 03:53:33PM +0200, Michael Tuexen wrote: >> >> >> ... >> >> >>> So... one of the machines on which I track head got this, as = well -- my >> >> >>> (mostly-)headless build machine. (2 laptops, updated in sync = with the >> >> >>> build machine, did not panic. One of those also uses a wired = NIC.) >> >> >> Do the network drivers of the machines not being affected use = iflib? >> >> >=20 >> >> > Apparently not -- they are em(4), iwm(4), & iwn(4), while the = panicking >> >> > machine uses igb(4). >> >> >=20 >> >> >> I do see the problem also on one of my machines and local = testing shows that >> >> >> = https://cgit.FreeBSD.org/src/commit/?id=3D3fade68cfdf95ee0b517b5d69b270bd8= da633404 = >> >> >> is the problem. At least reverting it locally resolves the = problem. >> >> >> Can you confirm this? >> >> >=20 >> >> > I can, and do: after reverting main-n285140-3fade68cfdf9 & = rebuilding, >> >> > I am able to ssh in without issue; the machine reports: >> >> >=20 >> >> > freebeast(16.0-C)[2] uname -aUK >> >> > FreeBSD freebeast.catwhisker.org 16.0-CURRENT FreeBSD = 16.0-CURRENT #549 main-n285180-23a84efeb191: Sat Apr 18 17:01:25 UTC = 2026 = root@freebeast.catwhisker.org:/common/S3/obj/usr/src/amd64.amd64/sys/GENER= IC amd64 1600015 1600015 >> >> >=20 >> >> > Thanks! >> >> You could also disable TSO. I will put up a review for a fix soon. >> >>=20 >> >> Best regards >> >> Michael >> >> >=20 >> >> > Peace, >> >> > david >> >> > --=20 >> >> > David H. Wolfskill = david@catwhisker.org >> >> >=20 >> >> > See https://www.catwhisker.org/~david/publickey.gpg for my = public key. >> >>=20 >> >>=20 >> >>=20 >> >=20 >>=20 >>=20 >=20