Date: Wed, 3 Apr 2024 17:43:22 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Nuno Teixeira <eduardo@freebsd.org> Cc: Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cfc667547715 - main - net/td-system-tools: Update to new release 1.6.0 Message-ID: <Zg2VOr0Tl32FS4Sa@FreeBSD.org> In-Reply-To: <CAFDf7U%2BOeTfBOXqmOe20joiG8fOr0pxv4n1jyZ0BjLmm8CM0tw@mail.gmail.com> References: <202404011642.431GgCDV071450@gitrepo.freebsd.org> <CAFDf7U%2BOeTfBOXqmOe20joiG8fOr0pxv4n1jyZ0BjLmm8CM0tw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 01, 2024 at 11:13:40PM +0100, Nuno Teixeira wrote: > -DISTVERSION= 1.5.6 > +PORTVERSION= 1.6.0 > > More a more I see committers changing from DISTVERSION to PORTVERSION. > Did I missed something about it? In this particular case it means the same thing, due to its simplicity. Traditionally we used PORTVERSION by default and resorted to DISTVERSION for weird version numbers. Several years ago PHB had started to recommend DISTVERSION as default, for kind of valid reasons, but many of us old-farts disagree with the extra cognitive load it entails and prefer the old school. TL;DR: so long as it DTRT, it's a matter of personal taste, and e.g. even though I prefer PORTVERSION, I won't switch away from DISTVERSION when it breaks blaming. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zg2VOr0Tl32FS4Sa>