From owner-cvs-src-old@FreeBSD.ORG Wed Dec 16 10:49:03 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B4C31065692 for ; Wed, 16 Dec 2009 10:49:03 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 862058FC0C for ; Wed, 16 Dec 2009 10:49:03 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id nBGAn36A071454 for ; Wed, 16 Dec 2009 10:49:03 GMT (envelope-from luigi@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id nBGAn3uU071453 for cvs-src-old@freebsd.org; Wed, 16 Dec 2009 10:49:03 GMT (envelope-from luigi@repoman.freebsd.org) Message-Id: <200912161049.nBGAn3uU071453@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to luigi@repoman.freebsd.org using -f From: Luigi Rizzo Date: Wed, 16 Dec 2009 10:48:40 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet/ipfw ip_dummynet.c ip_fw2.c ip_fw_dynamic.c ip_fw_log.c ip_fw_nat.c ip_fw_pfil.c ip_fw_private.h ip_fw_sockopt.c ip_fw_table.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2009 10:49:03 -0000 luigi 2009-12-16 10:48:40 UTC FreeBSD src repository Modified files: sys/netinet/ipfw ip_dummynet.c ip_fw2.c ip_fw_dynamic.c ip_fw_log.c ip_fw_nat.c ip_fw_pfil.c ip_fw_private.h ip_fw_sockopt.c ip_fw_table.c Log: SVN rev 200601 on 2009-12-16 10:48:40Z by luigi Various cosmetic cleanup of the files: - move global variables around to reduce the scope and make them static if possible; - add an ipfw_ prefix to all public functions to prevent conflicts (the same should be done for variables); - try to pack variable declaration in an uniform way across files; - clarify some comments; - remove some misspelling of names (#define V_foo VNET(bar)) that slipped in due to cut&paste - remove duplicate static variables in different files; MFC after: 1 month Revision Changes Path 1.14 +1 -0 src/sys/netinet/ipfw/ip_dummynet.c 1.28 +89 -92 src/sys/netinet/ipfw/ip_fw2.c 1.2 +13 -8 src/sys/netinet/ipfw/ip_fw_dynamic.c 1.2 +1 -4 src/sys/netinet/ipfw/ip_fw_log.c 1.8 +1 -0 src/sys/netinet/ipfw/ip_fw_nat.c 1.8 +39 -5 src/sys/netinet/ipfw/ip_fw_pfil.c 1.3 +19 -23 src/sys/netinet/ipfw/ip_fw_private.h 1.2 +11 -6 src/sys/netinet/ipfw/ip_fw_sockopt.c 1.2 +9 -5 src/sys/netinet/ipfw/ip_fw_table.c