From owner-cvs-all Mon Apr 15 6:10:59 2002 Delivered-To: cvs-all@freebsd.org Received: from cheer.mahoroba.org (flets20-089.kamome.or.jp [218.45.20.89]) by hub.freebsd.org (Postfix) with ESMTP id 8963537B400; Mon, 15 Apr 2002 06:10:49 -0700 (PDT) Received: from piano.mahoroba.org (IDENT:hR5GMsF8n0KrzZF1sgYKIrfcwBEHlegahsMLpWd8IoZdJS9cV+qLfS160D8b6O84@piano.mahoroba.org [IPv6:2001:200:301:0:240:96ff:fe48:4ea8]) (user=ume mech=CRAM-MD5 bits=0) by cheer.mahoroba.org (8.12.3/8.12.3) with ESMTP/inet6 id g3FDAeH9096835 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Mon, 15 Apr 2002 22:10:46 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Mon, 15 Apr 2002 22:10:40 +0900 Message-ID: From: Hajimu UMEMOTO To: Jacques Vidrine Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include unistd.h src/lib/libc/net Makefile.inc rcmd.c rcmdsh.3 rcmdsh.c In-Reply-To: <200204151252.g3FCqYJ21117@freefall.freebsd.org> References: <200204151252.g3FCqYJ21117@freefall.freebsd.org> User-Agent: xcite1.38> Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 4.5-STABLE MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by AMaViS-perl11-milter (http://amavis.org/) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, >>>>> On Mon, 15 Apr 2002 05:52:34 -0700 (PDT) >>>>> Jacques Vidrine said: nectar> nectar 2002/04/15 05:52:34 PDT nectar> Modified files: (Branch: RELENG_4) nectar> include unistd.h nectar> lib/libc/net Makefile.inc rcmd.c nectar> Added files: (Branch: RELENG_4) nectar> lib/libc/net rcmdsh.3 rcmdsh.c nectar> Log: nectar> MFC: 1.44 include/unistd.h nectar> 1.2 lib/libc/net/rcmdsh.3 nectar> 1.3 lib/libc/net/rcmdsh.c nectar> 1.43 lib/libc/net/Makefile.inc nectar> 1.32 lib/libc/net/rcmd.c nectar> Support for specifying rsh alternative. It seems rcmdsh() prevents from using IP address by following code: /* Validate remote hostname. */ if (strcmp(*ahost, "localhost") != 0) { if ((hp = gethostbyname(*ahost)) == NULL) { herror(*ahost); return (-1); } *ahost = hp->h_name; } There is similar codo with rcmdsh() in NetBSD's rcmd.c, but without above checking. It seems it is better removing above checking. Furthermore, the code is strict to an IPv4. So, if leaving it as is, I'll change it to use getaddrinfo(). -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message